fix: SuggestionPlugin support Composition event

[ClytzeL]

fix #1283 /claim #1283

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
blocknote	✅ Ready (Inspect)	Visit Preview	Dec 3, 2024 6:12am

[vercel[bot]]

Someone is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

[algora-pbc[bot]]

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

[YousefED]

• Can you explain why there was a different PR necessary?
• Why do we need to listen to domevents manually, can't we check view.composing like here? https://github.com/ueberdosis/tiptap/commit/9789372cea901b21059d53c30ff301efb35fb720

[ClytzeL]

• Can you explain why there was a different PR necessary?
• Why do we need to listen to domevents manually, can't we check view.composing like here? ueberdosis/tiptap@9789372

@YousefED
1.A different PR here because #1292 can not match my requirement. And I had changed source code in my project.I wish these changes can commit to the upstream blocknote. 2.I am not familiar with tiptap and before coding I had missed the information.I will try this.Thans for your advice.

[YousefED]

1.A different PR here because https://github.com/TypeCellOS/BlockNote/pull/1292 can not match my requirement. And I had changed source code in my project.I wish these changes can commit to the upstream blocknote.

Can you explain why on that PR? (I mean, can you a comment on that PR why there is an issue?)

[ClytzeL]

1.A different PR here because #1292 can not match my requirement. And I had changed source code in my project.I wish these changes can commit to the upstream blocknote.

Can you explain why on that PR? (I mean, can you a comment on that PR why there is an issue?)

@YousefED You would like me to comment on #1292 ?

[YousefED]

yes

On Mon, Dec 9, 2024 at 6:06 AM ClytzeL @.***> wrote:

1.A different PR here because #1292 https://github.com/TypeCellOS/BlockNote/pull/1292 can not match my requirement. And I had changed source code in my project.I wish these changes can commit to the upstream blocknote.

Can you explain why on that PR? (I mean, can you a comment on that PR why there is an issue?)

@YousefED https://github.com/YousefED You would like me to comment on #1292 https://github.com/TypeCellOS/BlockNote/pull/1292 ?

— Reply to this email directly, view it on GitHub https://github.com/TypeCellOS/BlockNote/pull/1295#issuecomment-2526901557, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC2BWMOTWLCIHN6CNPLKDD2EUQMJAVCNFSM6AAAAABS2SIQ3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRWHEYDCNJVG4 . You are receiving this because you were mentioned.Message ID: @.***>