TypeCellOS
request suggestion menu mentions to support CompositionEvent for chinese input
Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like A clear and concise description of what you want to happen.
Will you could support suggestion menu mentions with chinese search,ref: https://developer.mozilla.org/zh-CN/docs/Web/API/CompositionEvent
Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.
Additional context Add any other context or screenshots about the feature request here.
Bonus [ ] I'm a sponsor and would appreciate if you could look into this sooner than later π
Thanks for the report. The change would probably need to be made in this file: https://github.com/TypeCellOS/BlockNote/blob/main/packages/core/src/extensions/SuggestionMenu/SuggestionPlugin.ts
This (from a different project) might be a helpful pointer: https://github.com/ueberdosis/tiptap/commit/9789372cea901b21059d53c30ff301efb35fb720
/bounty 10
π $10 bounty β’ BlockNote
Steps to solve:
-
Start working: Comment
/attempt #1283with your implementation plan -
Submit work: Create a pull request including
/claim #1283in the PR body to claim the bounty - Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts
Thank you for contributing to TypeCellOS/BlockNote!
Add a bounty β’ Share on socials
| Attempt | Started (GMT+0) | Solution |
|---|---|---|
| π΄ @Anshgrover23 | Nov 28, 2024, 9:49:12 AM | WIP |
| π’ @mehul-m-prajapati | Nov 29, 2024, 8:16:29 PM | WIP |
| π’ @Recxsmacx | Feb 24, 2025, 6:54:35 AM | WIP |
| π’ @ClytzeL | #1295 |
![algora-pbc[bot] avatar](https://avatars.githubusercontent.com/in/275896?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ClytzeL can you see if this fixes it? https://github.com/TypeCellOS/BlockNote/pull/1292#issuecomment-2508583277
@ClytzeL can you see if this fixes it? #1292 (comment)
@YousefED @mehul-m-prajapati Thanks for support.There is still a little problem.I had already comment in the commit.Thanks again!
By the way,I would like to ask how to debug the @blocknote/core package in my project. Since the @blocknote/react package internally depends on a fixed version of @blocknote/core, I cannot change the version of @blocknote/core by only modifying it. My project uses Turbo + pnpm. Thank you for your help.
@ClytzeL : I have updated the code as per the review comment. Please test again and let me know if it works now.
@ClytzeL : I have updated the code as per the review comment. Please test again and let me know if it works now.
@mehul-m-prajapati Thanks for support.Would you show me how to test this #1292 before npm publish?
@ClytzeL : I have updated the code as per the review comment. Please test again and let me know if it works now.
@mehul-m-prajapati Thanks for support.Would you show me how to test this #1292 before npm publish?
I don't know how to test it before npm publish. @YousefED : Can you please help on this?
@mehul-m-prajapati Wlould you test on this preview link:https://blocknote-git-fork-mehul-m-prajapati-compositio-59cce9-typecell.vercel.app/custom-schema/suggestion-menus-mentions
Maybe this commit has regression.When I input @stοΌI can not filter steve in the list.Thanks for support.
π‘ @ClytzeL submitted a pull request that claims the bounty. You can visit your bounty board to reward.
#1295 I have tested this in my project.fix safari selection change case suggestion close when in composition event.
