BlockNote icon indicating copy to clipboard operation
BlockNote copied to clipboard

Input requiring conversion to LinkToolbar in CJK environment results in double input

Open Aoichaan0513 opened this issue 1 year ago • 2 comments

Describe the bug This problem occurs mainly when using languages that require conversion, such as Japanese, Chinese, and Korean. Specifically, when using the LinkToolbar to input text that needs to be converted, the confirmed text is double-entered. This should be remedied by changing the conditional branch in this section as follows.

if (event.key === “Enter” && !event.isComposing) {

To Reproduce

https://github.com/user-attachments/assets/8192e452-c86b-4538-b9cb-efb2efca197e

Misc

  • Node version: 20.11.0
  • Package manager: Yarn 4.3.1
  • Browser: Google Chrome 128.0.6613.120
  • [ ] I'm a sponsor and would appreciate if you could look into this sooner than later 💖

Aoichaan0513 avatar Sep 10 '24 14:09 Aoichaan0513

Thanks for reporting this! Since you already found the source of the problem and the solution, do you want to go ahead and make a PR for this? We should be able to pretty much merge it straight away

matthewlipski avatar Sep 11 '24 01:09 matthewlipski

That invitation is greatly appreciated! However, it has become very difficult for me to devote resources these days, so I hope I can leave it to you.

Aoichaan0513 avatar Sep 18 '24 00:09 Aoichaan0513