Tyler Yep comments

Results 75 comments of


                                            Tyler Yep

summary does not work for CLIP models (jit)

It looks like CLIP switched to using non-JIT by default, which is why this code started working on recent versions: https://github.com/openai/CLIP/commit/db20393f4affd4158528bd868478e516ebed0944 @mert-kurttutan Loading the model with `clip.load(..., jit=True)` would likely...

Summary doesn't give the number of parameters for a GCN

Please try using the latest version of `torchinfo`, thanks!

remove, or add a new flag for removing, "(recursive)" rows in the reported table

Adding this option makes sense to me. I definitely don't think is should be the default though - there's a lot more value added by being able to see which...

add show recursive option and add to default row setting

Please remove this option from the "defaults" section. We shouldn't change the default behavior. Also, I think the proposed output is quite confusing, since it looks like the DotProductAttention layers...

add show recursive option and add to default row setting

Also, it would be great if you could add a test case for this feature!

add show recursive option and add to default row setting

Let's keep the input shapes and column shapes for recursive layers. Keeping the recursive layers that don't have parameters is not ideal, but okay for now since there is currently...

add show recursive option and add to default row setting

Closing in favor of #174. Thank you for the work here and the feature suggestion!

Wrong recursive tag and duplicated/unordered entries

Thanks for reporting this issue! PRs to fix this are much appreciated.

Wrong recursive tag and duplicated/unordered entries

Feel free to open the PR (even if it is a draft) and we can discuss the issues on the PR itself

TypeError: rand() argument after * must be an iterable, not int

See #124