logging icon indicating copy to clipboard operation
logging copied to clipboard

color_scheme arg is not being used

Open lardcanoe opened this issue 8 years ago • 1 comments

https://github.com/TwP/logging/blob/master/lib/logging.rb#L94

:color_scheme should be part of that array.

Without it I don't get colorized log output.

I'll open a PR if you agree that this is an oversight. Thanks!

lardcanoe avatar May 08 '17 20:05 lardcanoe

Ah, I see what you're saying here. As the code stands right now, you cannot add colorization to a simple Logger instance created via the Logging.logger() method. You are proposing that :color_scheme be added as an option to the method.

:+1:

If you would love to take a stab at implementing the functionality, then please go ahead. Pull requests are always welcome :bowing_man:

TwP avatar May 21 '17 19:05 TwP