NormalizingFlows.jl icon indicating copy to clipboard operation
NormalizingFlows.jl copied to clipboard

more NF examples

Open zuhengxu opened this issue 2 years ago • 6 comments

as per issue #15

zuhengxu avatar Jul 13 '23 05:07 zuhengxu

@zuhengxu, can you push to merge this PR if nothing significant is standing? Thanks!

yebai avatar Mar 05 '25 20:03 yebai

No prob! I'll get back to this PR this weekend and hopefully merge it ASAP.

zuhengxu avatar Mar 06 '25 06:03 zuhengxu

Could we add a script to test whether all the example models run, e.g. on buildkite GPU?

yebai avatar Apr 10 '25 21:04 yebai

Yes, let me clean up the Ham VI demo and then add the test script. Currently I can confirm that all the examples run on CPUs by doing

include("demo_..._fllow.jl")

zuhengxu avatar Apr 10 '25 22:04 zuhengxu

Could we add a script to test whether all the example models run, e.g. on buildkite GPU?

@yebai Currently all the examples are only tested on CPUs. Do you have examples of such script (for testing runs) that I can refer to? (I did do include(...jl) manually for all the demos though.)

In terms of GPU, shall we first merge this PR and do GPU examples/test (#49) on a separate PR? the purpose this PR is just to demonstrate how to define and customize flow layers (at least for those popular flows). I think that to properly take advantage of GPU, we might want some interface adjustment.

zuhengxu avatar Apr 12 '25 01:04 zuhengxu

Currently all the examples are only tested on CPUs. Do you have examples of such a script (for testing runs) that I can refer to? (I did do include(...jl) manually for all the demos though.)

It is probably okay to create a new CI group called NF Examples and include all examples there. If running all examples is time-consuming, we could run only a few iterations and not wait for the convergence. This is mainly to ensure all examples can still run with new releases or PRs.

In terms of GPU, shall we first merge this PR and do GPU examples/test (https://github.com/TuringLang/NormalizingFlows.jl/issues/49) on a separate PR?

No problem -- it sounds good!

yebai avatar Apr 14 '25 14:04 yebai