AbstractMCMC.jl icon indicating copy to clipboard operation
AbstractMCMC.jl copied to clipboard
verified publisher icon TuringLang

Default `bundle_samples` is quite annoying

Open torfjelde opened this issue 3 years ago • 1 comments

The default implementation of bundle_samples specializes on Vector{T}, which in becomes very annoying if you want to implement your own bundle_samples, e.g. if you then use AbstractVector you almost immediately run into ambiguity errors.

https://github.com/TuringLang/AbstractMCMC.jl/blob/7192263f967b4a6bb1f78957c734a6a41c383026/src/interface.jl#L38-L44

In addition, IIUC it seems quite "useless" given that by default sample already returns a Vector of the transitions?

Thoughts on removing this?

torfjelde avatar Mar 10 '23 16:03 torfjelde

Do you have any thoughts on this @devmotion ?

torfjelde avatar Mar 10 '23 16:03 torfjelde