TurboWarp
Enhanced extension: Complexify!.js
A better extension for complex numbers, fixing all the issues with the original Complexity! See the first one at #2091 More motion, vectors, decimals and factorials**********!
*[Somehow not working]
This is riddled with licensing issues, poor code formatting, horrible practices and lots of spelling mistakes, I am making this a draft until further notice...
Generally speaking you should try to follow formatting best practices so your code doesn't look cluttered. Additionally, try to avoid opening new pull requests when it isn't necessary and you could just update the original :)
@Brackets-Coder, I'm new to JS and GitHub and that sort of stuff. I don't know a lot of things. Some things, but not all of them. I didn't knew that you could edit pull-requesting files until recently, after I created this new pull request. But don't take me like an ignorant either. I may be learning English and JS, but I learned enough to understand what you're saying. I'll always try my best to reach my goal, even if it takes me a new set of rules to learn. So don't expect me to be a perfect coder, nor be a random guy that has a laptop and asks ChatGPT and other coders to do all work for him. Just wanting to point that out. Also, @yuri-kiss, what's wrong about the licence? ClickerTale_2 used MPL-2.0, as reccomended by the CONTRIBUTING.md,
This is riddled with licensing issues, poor code formatting, horrible practices and lots of spelling mistakes, I am making this a draft until further notice...
And which are the horrible practices? Now that I know how to edit files, maybe I can correct Complexify!.js
Generally speaking you should try to follow formatting best practices so your code doesn't look cluttered. Additionally, try to avoid opening new pull requests when it isn't necessary and you could just update the original :)
@Brackets-Coder, I'm new to JS and GitHub and that sort of stuff. I don't know a lot of things. Some things, but not all of them. I didn't knew that you could edit pull-requesting files until recently, after I created this new pull request. But don't take me like an ignorant either. I may be learning English and JS, but I learned enough to understand what you're saying. I'll always try my best to reach my goal, even if it takes me a new set of rules to learn. So don't expect me to be a perfect coder, nor be a random guy that has a laptop and asks ChatGPT and other coders to do all work for him. Just wanting to point that out. Also, @yuri-kiss, what's wrong about the licence? ClickerTale_2 used MPL-2.0, as reccomended by the CONTRIBUTING.md,
This is riddled with licensing issues, poor code formatting, horrible practices and lots of spelling mistakes, I am making this a draft until further notice...
And which are the horrible practices? Now that I know how to edit files, maybe I can correct Complexify!.js
Absolutely not trying to be critical, we all were there once and it was only recently (in the past few months) that I really started with Github. It's an understandable situation, I'm just here to try to help you through it.
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.
After ~half an hour~ hours of coding, I got it. No more untranslated strings, no more wierd formatting, no more distracting comments, and no more horrible practices. Only Complexify!, no more.
Thanks @Brackets-Coder for telling me where I could be better. Thanks @yuri-kiss for telling me some tips and in what I was wrong. Thanks @CubesterYT and @CubesterYT for just passing by. And thanks @Clickertale2 for being always there, always helping.
Fixing such a wierd extension is truly hard, but enhancing #2091 was really worth it. All three checks are done, all three green successful checks. I'm not sure what's next, do I just keep waiting? Do I start making the image? Or did it ended before its start?
What now?
(also i thought !format just meant my formatting wasn't good, my bad)
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.
For now, we'll go through the next round of reviews before merging just to make sure everything is perfect and add some policing details before it gets merged. It's going to be really nitpicky and specific and detailed so just warning you ahead of time if some requests seem odd.
Additionally, we strongly recommend a gallery thumbnail, so if you haven't started making that you should do that now or generate one with a tool of your choice (assuming proper attribution and credit of sources). If you like, you can also write documentation and add sample projects, but these aren't required.
Also make sure the extension still works the same after all those changes
@CubesterYT: Also make sure the extension still works the same after all those changes
It does! Maybe I'll edit it in the future due to silly factorial issues (of course, I set hideFromPalette: true to every factorial-related), but outside of that it's safe to use. I tested it, and if it doesn't- please tell me!
A teeny-tiny change just for it to be better [bet you won't notice] but it's not like the !format is wrong
Don't be surprised if I update this. It's not like new colors or documentation or something like that...
@Kenay555 I am willing to review this code, but I first need to address some copyright concerns. Did you copy any of your code verbatim from an external source (ChatGPT, someone else's code, etc.)?
@Kenay555 I am willing to review this code, but I first need to address some copyright concerns. Did you copy any of your code verbatim from an external source (ChatGPT, someone else's code, etc.)?
Well... we used Rawify's complex.js library, which I guess that counts. More about the licence inside the extension
@Kenay555 Your extension adds over 2000 lines of code to the extension library, and at least 53 of those lines do not actually do anything. The whole thing looks like it was over-commented with a slight sense of humor. While we all love funny source code comments, the codebase needs to be sterilized of unprofessionalism before being introduced.
@Kenay555 Your extension adds over 2000 lines of code to the extension library, and at least 53 of those lines do not actually do anything. The whole thing looks like it was over-commented with a slight sense of humor. While we all love funny source code comments, the codebase needs to be sterilized of unprofessionalism before being introduced.
Ok... I don't know how you want it to 'be sterilized of unprofessionalism', but i'll try my best. Also I'm planning to re-work the library from scratch (pun NOT intended) since it's just plain wierd, now that I made two more extensions (not planning to fork) I think I know enough JS to handle this by myself. Well, guess it's time to convert this personal proyect into something big. Again. ~(like i'm barely finishing school and now i have to work as an software engineer?)~
@Kenay555 Your extension adds over 2000 lines of code to the extension library, and at least 53 of those lines do not actually do anything. The whole thing looks like it was over-commented with a slight sense of humor. While we all love funny source code comments, the codebase needs to be sterilized of unprofessionalism before being introduced.
Ok... I don't know how you want it to 'be sterilized of unprofessionalism', but i'll try my best. Also I'm planning to re-work the library from scratch (pun NOT intended) since it's just plain wierd, now that I made two more extensions (not planning to fork) I think I know enough JS to handle this by myself. Well, guess it's time to convert this personal proyect into something big. Again. ~(like i'm barely finishing school and now i have to work as an software engineer?)~
You don't have to do too much, just strip comments that wouldn't help a reviewer understand your code better (for example, personal commentary).
Minor nitpick, but if you aren't a software engineer, why are you trying to add more code for us to maintain?
Also, this is a duplicate of #1861 Maybe consider collaborating on one extension?
Also, this is a duplicate of #1861 Maybe consider collaborating on one extension?
I agree.
Also, this is a duplicate of #1861 Maybe consider collaborating on one extension?
I agree.
Ok, lemme tell him about it, and see if i can put Quaternions for the full package