action-deploy-theme icon indicating copy to clipboard operation
action-deploy-theme copied to clipboard

yarn zip is not being used by the github action

Open pradeep-dfi opened this issue 1 year ago • 1 comments

When I look at the source theme repo, it has yarn zip to generate the theme zip which uses gulp internally.

Considering that github actions does direct zipping, things seem to be not working as expected.

I have added a custom js file which is part of the zip prepared by the github actions, but it actually doesn't get used after getting uploaded to ghost. Ghost seems to generate a source.js file at some point which doesn't contain the custom js file that I added.

Is there a reason why yarn zip is not used to package the theme?

pradeep-dfi avatar Mar 13 '24 06:03 pradeep-dfi

Hi, just wanted to piggy back , seems it doesn't build the theme css. Is that because of the yarn zip ? basically doesnt npm run zip

russkiimike avatar Oct 06 '24 10:10 russkiimike