Source icon indicating copy to clipboard operation
Source copied to clipboard

Remove weird pagination that read all posts regardless of the collections filter

Open davidfraser opened this issue 1 year ago • 2 comments

If I have a fairly standard collection that uses the index feed, it shows items on the second page as you scroll down that don't match it's filter. For example with the following routes.yaml:

routes:
  /: home

collections:
  /blog/:
    permalink: /blog/{year}/{month}/{slug}/
    filter: primary_tag:blog

Then items that don't have their primary tag as blog still appear. This seems to be fairly directly caused by this unfiltered #get on page 2 in the source code, which I don't see any reason for... (obviously I may be missing something, please say!)

davidfraser avatar Jan 17 '25 10:01 davidfraser

I see that this is actually reported as #33

davidfraser avatar Jan 17 '25 10:01 davidfraser

@minimaluminium I saw you said in https://github.com/TryGhost/Source/issues/33#issuecomment-2750432999 that there was a special trick needed to make get queries work with advanced layout options. But what I see here looks like a strange second page that uses a different query to the other pages. I can't find much explanation in the history as to why this is the case, it just looks like it's been inherited through a few files and originated here
Would you be able to perhaps explain why this is needed?

davidfraser avatar Apr 29 '25 13:04 davidfraser