Added share modal in Analytics
ref https://linear.app/ghost/issue/PROD-1856/post-analytics-page-share-modal
- Post share dialog was missing in traffic and post analytics. This PR replicates the existing dialog (with some minor size adjustments) in Shade as a feature component
Walkthrough
This change set introduces a comprehensive post sharing feature across the analytics and stats views of the application. A new PostShareModal React component is implemented and exposed through the UI library, along with Storybook stories for demonstration and testing. The modal supports sharing posts via social platforms, copying links, and displays post metadata such as title, excerpt, authors, and site information. The stats API is refactored to fetch analytics for a specific post by ID rather than just the latest post, affecting both backend endpoints and client-side data hooks. Context providers and test helpers are updated to include site metadata. The analytics and stats UIs are enhanced to integrate the share modal, with updated loading states and improved post and stats presentation. Additionally, a new hook is added to manage the post success modal, and admin routing logic is updated to conditionally navigate based on feature flags.
[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.
🔧 ESLint
If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
apps/stats/src/views/Stats/Overview/components/LatestPost.tsx
Oops! Something went wrong! :(
ESLint: 8.57.1
ESLint couldn't find the plugin "eslint-plugin-react-hooks".
(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "/apps/stats".)
It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm install eslint-plugin-react-hooks@latest --save-devThe plugin "eslint-plugin-react-hooks" was referenced from the config file in "apps/stats/.eslintrc.cjs".
If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.
apps/posts/src/views/PostAnalytics/PostAnalytics.tsx
Oops! Something went wrong! :(
ESLint: 8.57.1
ESLint couldn't find the plugin "eslint-plugin-react-hooks".
(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "/apps/posts".)
It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm install eslint-plugin-react-hooks@latest --save-devThe plugin "eslint-plugin-react-hooks" was referenced from the config file in "apps/posts/.eslintrc.cjs".
If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.
apps/posts/src/hooks/usePostSuccessModal.ts
Oops! Something went wrong! :(
ESLint: 8.57.1
ESLint couldn't find the plugin "eslint-plugin-react-hooks".
(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "/apps/posts".)
It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
npm install eslint-plugin-react-hooks@latest --save-devThe plugin "eslint-plugin-react-hooks" was referenced from the config file in "apps/posts/.eslintrc.cjs".
If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.
✨ Finishing Touches
- [ ] 📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Explain this complex logic. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai explain this code block. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read src/utils.ts and explain its main purpose. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai generate docstringsto generate docstrings for this PR. -
@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
The display is a bit diff but I think I've got wired up what's needed.
The excerpt isn't truncated is the main piece.
Codecov Report
Attention: Patch coverage is 39.68254% with 38 lines in your changes missing coverage. Please review.
Project coverage is 72.35%. Comparing base (
51d8753) to head (2496b4f). Report is 7 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #23873 +/- ##
=======================================
Coverage 72.35% 72.35%
=======================================
Files 1532 1532
Lines 112512 112530 +18
Branches 13776 13776
=======================================
+ Hits 81407 81423 +16
+ Misses 30091 30076 -15
- Partials 1014 1031 +17
| Flag | Coverage Δ | |
|---|---|---|
| admin-tests | 48.62% <25.00%> (-0.01%) |
:arrow_down: |
| e2e-tests | 72.35% <39.68%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.