Ghost icon indicating copy to clipboard operation
Ghost copied to clipboard

Update Istanbul timezone

Open muratcorlu opened this issue 1 year ago • 4 comments

Turkish time zone is set to GMT+3^1 since 2018^2. Current label indicates old state.

I'm not sure if I need to create a migration file for this change.

muratcorlu avatar May 08 '24 19:05 muratcorlu

The file looks like test fixtures, I think you need to update https://github.com/TryGhost/SDK/tree/main/packages/timezone-data

vikaspotluri123 avatar May 08 '24 20:05 vikaspotluri123

Oh, ok. I couldn't notice that. Then I'll close this and open a PR on SDK project. Thank you @vikaspotluri123

muratcorlu avatar May 08 '24 20:05 muratcorlu

Done: https://github.com/TryGhost/SDK/pull/495

muratcorlu avatar May 08 '24 20:05 muratcorlu

Actually, updating this fixture file stille makes sense after fixing the SDK, right?

muratcorlu avatar May 08 '24 20:05 muratcorlu

Thanks for the submission(s)! I merged the SDK package and I had to make other changes in https://github.com/TryGhost/Ghost/commit/c046bbda91761551e1f7a5942df2faa85c29f241 so this change was included there. Mentioned you in the commit 👍 .

9larsons avatar Nov 21 '24 18:11 9larsons