OpenGothic icon indicating copy to clipboard operation
OpenGothic copied to clipboard
verified publisher icon Try

Adress some swimming/diving related issues

Open thokkat opened this issue 3 years ago • 2 comments

Fixes the following bugs:

  • Camera stays under the character after diving to water surface.
  • ~~After flying out of water by help of marvin F8 the character stays in swimming state.~~
  • Too big health reduction after diving time is over. Vanilla is like 10dmg/s.

thokkat avatar Oct 08 '22 20:10 thokkat

Ok, waterRay gives wrong values if the water surface is not free. Guard against it by checking for !isDive().

thokkat avatar Oct 09 '22 01:10 thokkat

Actually swimming case works. Problematic cases are when you dive through the dam in the new camp in G1 or the paladin ship. There was also a bug depending on the orientation of the character.

I kicked it out and think about it again. I open a new PR if i come up with something useful.

thokkat avatar Oct 09 '22 18:10 thokkat

@Try Is there something that needs to be changed? I left marvin stuff out.

thokkat avatar Oct 19 '22 16:10 thokkat

Hi, sorry I kinda forgot about this PR, thank for poking me. Generally LGTM - will do testing today

Try avatar Oct 19 '22 17:10 Try