Trusted-AI
Bug fixes for the FACTS method
@hoffmansc
Wrote fixes for the bugs documented in issues #531 and #532.
For the issue of the hard-coded features in the recIsValid function (issue #531, code here), the fix currently proposed is a hotfix. The values have not been removed, only the relevant argument's default value has been changed from True to False.
Whether you would like us to remove this part of the code altogether or keep working on it to make it more robust (and if so, in this pull request or a new one), please let me know.
Fixes #531 and #532.
Hello! Thanks for the feedback. Apologies for the delayed response.
For https://github.com/Trusted-AI/AIF360/issues/531, it would be good to have a more robust system eventually
Ok, great, we will see to it as soon as possible and create a new PR.
For https://github.com/Trusted-AI/AIF360/issues/532, can we add a short test case like in the issue to show it's working?
Of course. So this one I will add to this PR right?
Hello again @hoffmansc !
I have now added a test showcasing that the costs are computed correctly (close to the example in #532). Just a question to be sure I understood correctly, is this what you meant? Or by "test case" you mean also to add something to the example notebook for example?
Other than, I think we are good to go.