Modular-Item-API icon indicating copy to clipboard operation
Modular-Item-API copied to clipboard

Heavy Attack Doesn't Multiply Outgoing Damage

Open CSNinja1 opened this issue 1 year ago • 7 comments

The Heavy Attack does not multiply the damage of the weapon properly when a mob is attacked with it.

Here is a video demonstrating the Issue. https://github.com/user-attachments/assets/5eccf325-d9bf-456a-9b1e-fedbe17c7649

This is persistent through forge and fabric versions.

CSNinja1 avatar Oct 08 '24 19:10 CSNinja1

Furthermore, the shield break attribute of the greatsword doesn't function with both regular and heavy attacks

Video for demonstration https://github.com/user-attachments/assets/fccc63fd-93f1-4f48-8bb5-8a801dc6a2c9

It is possible that the target dummy with a shield that was used in the demonstration somehow worked differently to a player holding out a shield, meaning that against a player the shield break attribute might work as intended. I don't have another player to test that though.

CSNinja1 avatar Oct 09 '24 05:10 CSNinja1

Shield break only works against players, this is intended this way

Smartin-b avatar Oct 09 '24 05:10 Smartin-b

ok, thank you for the conformation.

CSNinja1 avatar Oct 09 '24 05:10 CSNinja1

the missing damage multiplication should be fixed in the next release

Smartin-b avatar Oct 09 '24 05:10 Smartin-b

what mod are you using that this happens to the enchanting glint?

Smartin-b avatar Oct 09 '24 05:10 Smartin-b

are you, by any chance, using really old versions of sodium? if yes, you should upate, that issue is fixed on newer versions of sodium

Smartin-b avatar Oct 09 '24 05:10 Smartin-b

I am using the rubidium fork of sodium, and it seems to be no longer supported after a closer look. I'll likely replace it with Embeddium.

CSNinja1 avatar Oct 09 '24 07:10 CSNinja1