Modular-Item-API icon indicating copy to clipboard operation
Modular-Item-API copied to clipboard
Published 2 months ago • verified publisher icon Truly-Modular

Potential Race Condition Crash

Open Provismet opened this issue 1 year ago • 2 comments

Describe the bug When attacking an entity, the damage event has a chance to cause a ConcurrentModificationError and crash the game. This is happening within the RedPxnda Nucleus library.

From what I can tell, this appears to be a somewhat rare issue, this crash also did not occur on subsequent attempts with the exact same environment.

To Reproduce Due to the nature of this error, it will be difficult to reliably reproduce.

Steps to reproduce the behavior:

  1. Attack a mob with a modular weapon.

Minecraft and Mod Version: Minecraft: 1.20.1 Forge/Fabric: Fabric Miapi: 1.1.31-1.20.1-fabric other:

Full Mod List

  • Architectuary API
  • Fabric API
  • Cloth Config API
  • Mod Menu
  • Provi's Health Bars
  • Combat+ Core
  • Dual Swords
  • Truly Modular: Modular Item API
  • Truly Modular: Modular Arsenal

Ingame Logs

full log 
[23:05:25] [main/INFO]: Loading Minecraft 1.20.1 with Fabric Loader 0.16.3
[23:05:25] [main/INFO]: Loading 75 mods:
	- architectury 9.2.14
	- arsenal 1.10
	- cloth-config 11.1.118
	   \-- cloth-basic-math 0.6.1
	- combat-plus-core 1.1.0+1.20.1
	   |-- lilylib 1.1.3+1.20
	   \-- mm 2.3
	- dualswords 1.1.2+1.20.1
	- fabric-api 0.92.2+1.20.1
	   |-- fabric-api-base 0.4.31+1802ada577
	   |-- fabric-api-lookup-api-v1 1.6.36+1802ada577
	   |-- fabric-biome-api-v1 13.0.13+1802ada577
	   |-- fabric-block-api-v1 1.0.11+1802ada577
	   |-- fabric-block-view-api-v2 1.0.1+1802ada577
	   |-- fabric-blockrenderlayer-v1 1.1.41+1802ada577
	   |-- fabric-client-tags-api-v1 1.1.2+1802ada577
	   |-- fabric-command-api-v1 1.2.34+f71b366f77
	   |-- fabric-command-api-v2 2.2.13+1802ada577
	   |-- fabric-commands-v0 0.2.51+df3654b377
	   |-- fabric-containers-v0 0.1.64+df3654b377
	   |-- fabric-content-registries-v0 4.0.11+1802ada577
	   |-- fabric-convention-tags-v1 1.5.5+1802ada577
	   |-- fabric-crash-report-info-v1 0.2.19+1802ada577
	   |-- fabric-data-attachment-api-v1 1.0.0+de0fd6d177
	   |-- fabric-data-generation-api-v1 12.3.4+1802ada577
	   |-- fabric-dimensions-v1 2.1.54+1802ada577
	   |-- fabric-entity-events-v1 1.6.0+1c78457f77
	   |-- fabric-events-interaction-v0 0.6.2+1802ada577
	   |-- fabric-events-lifecycle-v0 0.2.63+df3654b377
	   |-- fabric-game-rule-api-v1 1.0.40+1802ada577
	   |-- fabric-item-api-v1 2.1.28+1802ada577
	   |-- fabric-item-group-api-v1 4.0.12+1802ada577
	   |-- fabric-key-binding-api-v1 1.0.37+1802ada577
	   |-- fabric-keybindings-v0 0.2.35+df3654b377
	   |-- fabric-lifecycle-events-v1 2.2.22+1802ada577
	   |-- fabric-loot-api-v2 1.2.1+1802ada577
	   |-- fabric-loot-tables-v1 1.1.45+9e7660c677
	   |-- fabric-message-api-v1 5.1.9+1802ada577
	   |-- fabric-mining-level-api-v1 2.1.50+1802ada577
	   |-- fabric-model-loading-api-v1 1.0.3+1802ada577
	   |-- fabric-models-v0 0.4.2+9386d8a777
	   |-- fabric-networking-api-v1 1.3.11+1802ada577
	   |-- fabric-networking-v0 0.3.51+df3654b377
	   |-- fabric-object-builder-api-v1 11.1.3+1802ada577
	   |-- fabric-particles-v1 1.1.2+1802ada577
	   |-- fabric-recipe-api-v1 1.0.21+1802ada577
	   |-- fabric-registry-sync-v0 2.3.3+1802ada577
	   |-- fabric-renderer-api-v1 3.2.1+1802ada577
	   |-- fabric-renderer-indigo 1.5.2+85287f9f77
	   |-- fabric-renderer-registries-v1 3.2.46+df3654b377
	   |-- fabric-rendering-data-attachment-v1 0.3.37+92a0d36777
	   |-- fabric-rendering-fluids-v1 3.0.28+1802ada577
	   |-- fabric-rendering-v0 1.1.49+df3654b377
	   |-- fabric-rendering-v1 3.0.8+1802ada577
	   |-- fabric-resource-conditions-api-v1 2.3.8+1802ada577
	   |-- fabric-resource-loader-v0 0.11.10+1802ada577
	   |-- fabric-screen-api-v1 2.0.8+1802ada577
	   |-- fabric-screen-handler-api-v1 1.3.30+1802ada577
	   |-- fabric-sound-api-v1 1.0.13+1802ada577
	   |-- fabric-transfer-api-v1 3.3.5+8dd72ea377
	   \-- fabric-transitive-access-wideners-v1 4.3.1+1802ada577
	- fabricloader 0.16.3
	   \-- mixinextras 0.4.1
	- java 17
	- miapi 1.1.31
	   |-- com_ezylang_evalex 3.2.0
	   |-- nucleus 1.1.2
	   |-- nucleus_codec 1.1.4
	   |-- nucleus_config 1.1.5
	   |-- nucleus_facet 1.0.0
	   |-- nucleus_pose 1.0.0
	   \-- reach-entity-attributes 2.4.0
	- minecraft 1.20.1
	- modmenu 7.2.2
	- provihealth 1.2.4+1.20.1
	   \-- lilylib 1.1.3+1.20
[23:05:25] [main/INFO]: SpongePowered MIXIN Subsystem Version=0.8.7 Source=file:/C:/Users/Hyper/AppData/Roaming/ModrinthApp/meta/libraries/net/fabricmc/sponge-mixin/0.15.2+mixin.0.8.7/sponge-mixin-0.15.2+mixin.0.8.7.jar Service=Knot/Fabric Env=CLIENT
[23:05:26] [main/INFO]: Compatibility level set to JAVA_16
[23:05:26] [main/INFO]: Compatibility level set to JAVA_17
[23:05:26] [main/WARN]: Reference map 'Truly-Modular-arsenal-arsenal-common-refmap.json' for arsenal-common.mixins.json could not be read. If this is a development environment you can ignore this message
[23:05:27] [main/WARN]: Error loading class: io/github/apace100/apoli/util/StackPowerUtil (java.lang.ClassNotFoundException: io/github/apace100/apoli/util/StackPowerUtil)
[23:05:27] [main/WARN]: @Mixin target io.github.apace100.apoli.util.StackPowerUtil was not found miapi-common.mixins.json:ApoliStackPowerMixin from mod miapi
[23:05:27] [main/WARN]: Error loading class: net/archers/item/misc/AutoFireHook (java.lang.ClassNotFoundException: net/archers/item/misc/AutoFireHook)
[23:05:27] [main/WARN]: @Mixin target net.archers.item.misc.AutoFireHook was not found miapi-common.mixins.json:ArcheryHookMixin from mod miapi
[23:05:27] [main/WARN]: Error loading class: net/bettercombat/api/WeaponAttributesHelper (java.lang.ClassNotFoundException: net/bettercombat/api/WeaponAttributesHelper)
[23:05:27] [main/WARN]: @Mixin target net.bettercombat.api.WeaponAttributesHelper was not found miapi-common.mixins.json:BCWeaponRegistryMixin from mod miapi
[23:05:27] [main/INFO]: Initializing MixinExtras via com.llamalad7.mixinextras.service.MixinExtrasServiceImpl(version=0.4.1).
[23:05:34] [Datafixer Bootstrap/INFO]: 188 Datafixer optimizations took 175 milliseconds
[23:05:36] [Render thread/INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[23:05:37] [Render thread/INFO]: Setting user: Provismet
[23:05:37] [Render thread/INFO]: Registering S2C receiver with id miapi:defaultchannel
[23:05:37] [Render thread/INFO]: Registering C2S receiver with id miapi:defaultchannel
[23:05:37] [Render thread/ERROR]: No data fixer registered for miapi:thrown_item
[23:05:37] [Render thread/ERROR]: No data fixer registered for miapi:thrown_boomerang_item
[23:05:37] [Render thread/INFO]: Definitely not up to no good
[23:05:37] [Render thread/INFO]: Registering C2S receiver with id nucleus:main/9adc544263a13bf78e227a146d1695d9
[23:05:37] [Render thread/INFO]: Registering S2C receiver with id nucleus:main/9adc544263a13bf78e227a146d1695d9
[23:05:37] [Render thread/INFO]: Registering C2S receiver with id nucleus:main/fa77e039b1b63b568bcae468100327d5
[23:05:37] [Render thread/INFO]: Registering S2C receiver with id nucleus:main/fa77e039b1b63b568bcae468100327d5
[23:05:37] [Render thread/INFO]: Registering C2S receiver with id nucleus:main/c8c225b78d053e81a32b497bbcef005c
[23:05:37] [Render thread/INFO]: Registering S2C receiver with id nucleus:main/c8c225b78d053e81a32b497bbcef005c
[23:05:37] [Render thread/INFO]: Registering C2S receiver with id nucleus:main/427197c232643741b7368413806caf61
[23:05:37] [Render thread/INFO]: Registering S2C receiver with id nucleus:main/427197c232643741b7368413806caf61
[23:05:37] [Render thread/INFO]: Registering C2S receiver with id nucleus:main/c394df3298a034aab0e0f535c5df3ab1
[23:05:37] [Render thread/INFO]: Registering S2C receiver with id nucleus:main/c394df3298a034aab0e0f535c5df3ab1
[23:05:38] [Render thread/INFO]: Registered Truly Modulars Property resolvers:
[23:05:38] [Render thread/INFO]: registered resolver: miapi:module
[23:05:38] [Render thread/INFO]: registered resolver: miapi:module_data
[23:05:38] [Render thread/INFO]: registered resolver: miapi:skin
[23:05:38] [Render thread/INFO]: registered resolver: miapi:synergies
[23:05:38] [Render thread/INFO]: registered resolver: miapi:material_property
[23:05:38] [Render thread/INFO]: registered resolver: miapi:blueprint
[23:05:38] [Render thread/INFO]: Registering S2C receiver with id architectury:spawn_entity_packet
[23:05:38] [Render thread/INFO]: [Indigo] Registering Indigo renderer!
[23:05:38] [Worker-Main-1/INFO]: Checking mod updates...
[23:05:38] [Render thread/INFO]: Backend library: LWJGL version 3.3.1 SNAPSHOT
[23:05:40] [Render thread/INFO]: Reloading ResourceManager: vanilla, fabric (arsenal, cloth-config, combat-plus-core, dualswords, fabric-api, fabric-api-base, fabric-api-lookup-api-v1, fabric-biome-api-v1, fabric-block-api-v1, fabric-block-view-api-v2, fabric-blockrenderlayer-v1, fabric-client-tags-api-v1, fabric-command-api-v1, fabric-command-api-v2, fabric-commands-v0, fabric-containers-v0, fabric-content-registries-v0, fabric-convention-tags-v1, fabric-crash-report-info-v1, fabric-data-attachment-api-v1, fabric-data-generation-api-v1, fabric-dimensions-v1, fabric-entity-events-v1, fabric-events-interaction-v0, fabric-events-lifecycle-v0, fabric-game-rule-api-v1, fabric-item-api-v1, fabric-item-group-api-v1, fabric-key-binding-api-v1, fabric-keybindings-v0, fabric-lifecycle-events-v1, fabric-loot-api-v2, fabric-loot-tables-v1, fabric-message-api-v1, fabric-mining-level-api-v1, fabric-model-loading-api-v1, fabric-models-v0, fabric-networking-api-v1, fabric-networking-v0, fabric-object-builder-api-v1, fabric-particles-v1, fabric-recipe-api-v1, fabric-registry-sync-v0, fabric-renderer-api-v1, fabric-renderer-indigo, fabric-renderer-registries-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-rendering-v0, fabric-rendering-v1, fabric-resource-conditions-api-v1, fabric-resource-loader-v0, fabric-screen-api-v1, fabric-screen-handler-api-v1, fabric-sound-api-v1, fabric-transfer-api-v1, fabric-transitive-access-wideners-v1, fabricloader, lilylib, miapi, mm, modmenu, nucleus, nucleus_config, provihealth, reach-entity-attributes)
[23:05:40] [Worker-Main-1/INFO]: Found unifont_all_no_pua-15.0.06.hex, loading
[23:05:40] [Render thread/INFO]: Successfully created file watcher (and thread) for config folder. (C:\Users\Hyper\AppData\Roaming\ModrinthApp\profiles\phb test\config)
[23:05:40] [Worker-Main-4/WARN]: Texture miapi:item/skin/rainbow_animation_simple with size 1x32 limits mip level from 4 to 0
[23:05:40] [Worker-Main-4/WARN]: minecraft:textures/atlas/blocks.png: dropping miplevel from 4 to 0, because of minimum power of two: 1
[23:05:41] [Render thread/WARN]: Missing sound for event: minecraft:item.goat_horn.play
[23:05:41] [Render thread/WARN]: Missing sound for event: minecraft:entity.goat.screaming.horn_break
[23:05:41] [Render thread/INFO]: OpenAL initialized on device OpenAL Soft on VoiceMeeter Input (VB-Audio VoiceMeeter VAIO)
[23:05:41] [Render thread/INFO]: Sound engine started
[23:05:42] [Render thread/INFO]: Created: 1024x512x0 minecraft:textures/atlas/blocks.png-atlas
[23:05:42] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/signs.png-atlas
[23:05:42] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/shield_patterns.png-atlas
[23:05:42] [Render thread/INFO]: Created: 512x512x4 minecraft:textures/atlas/banner_patterns.png-atlas
[23:05:42] [Render thread/INFO]: Created: 1024x1024x4 minecraft:textures/atlas/armor_trims.png-atlas
[23:05:42] [Render thread/INFO]: Created: 128x64x4 minecraft:textures/atlas/decorated_pot.png-atlas
[23:05:42] [Render thread/INFO]: Created: 256x256x4 minecraft:textures/atlas/chest.png-atlas
[23:05:42] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/shulker_boxes.png-atlas
[23:05:42] [Render thread/INFO]: Created: 512x256x4 minecraft:textures/atlas/beds.png-atlas
[23:05:42] [Render thread/WARN]: Shader rendertype_entity_translucent_emissive could not find sampler named Sampler2 in the specified shader program.
[23:05:42] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/particles.png-atlas
[23:05:42] [Render thread/INFO]: Created: 256x256x0 minecraft:textures/atlas/paintings.png-atlas
[23:05:42] [Render thread/INFO]: Created: 256x128x0 minecraft:textures/atlas/mob_effects.png-atlas
[23:05:49] [Render thread/INFO]: [fabric-registry-sync] Loaded registry data [file 1/4]
[23:05:50] [Render thread/INFO]: Loaded 7 recipes
[23:05:50] [Render thread/INFO]: Loaded 1271 advancements
[23:05:50] [ForkJoinPool.commonPool-worker-1/WARN]: Module not found for bow_handle_normal Key - substituting with empty module
[23:05:50] [ForkJoinPool.commonPool-worker-1/WARN]: Module not found for bow_arms_normal Key - substituting with empty module
[23:05:50] [ForkJoinPool.commonPool-worker-1/WARN]: Module not found for bow_string_normal Key - substituting with empty module
[23:05:51] [ForkJoinPool.commonPool-worker-1/WARN]: ItemModule is null?
[23:05:51] [ForkJoinPool.commonPool-worker-1/INFO]: Loaded 41 Synergies
[23:05:51] [ForkJoinPool.commonPool-worker-1/INFO]: Loaded 1 Injectors/Property Substitutors
[23:05:51] [ForkJoinPool.commonPool-worker-1/INFO]: Loaded 63 Modules
[23:05:51] [ForkJoinPool.commonPool-worker-1/INFO]: Found 56 Enchantments
[23:05:51] [ForkJoinPool.commonPool-worker-1/INFO]: Loaded 313 Skins
[23:05:51] [ForkJoinPool.commonPool-worker-1/INFO]: Loaded 31 Modular Converters
[23:05:51] [ForkJoinPool.commonPool-worker-1/INFO]: Loaded 114 Materials
[23:05:51] [ForkJoinPool.commonPool-worker-1/INFO]: Server load took 965.5613000000001 ms
[23:05:51] [Render thread/INFO]: Applied 0 biome modifications to 0 of 64 new biomes in 2.206 ms
[23:05:51] [Server thread/INFO]: Starting integrated minecraft server version 1.20.1
[23:05:51] [Server thread/INFO]: Generating keypair
[23:05:51] [Server thread/INFO]: Preparing start region for dimension minecraft:overworld
[23:05:53] [Render thread/INFO]: Preparing spawn area: 0%
[23:05:53] [Render thread/INFO]: Preparing spawn area: 0%
[23:05:53] [Render thread/INFO]: Preparing spawn area: 0%
[23:05:53] [Render thread/INFO]: Preparing spawn area: 0%
[23:05:53] [Render thread/INFO]: Preparing spawn area: 0%
[23:05:53] [Render thread/INFO]: Preparing spawn area: 74%
[23:05:54] [Render thread/INFO]: Time elapsed: 2632 ms
[23:05:54] [Server thread/INFO]: Truly Modular will now go onto reload twice.
[23:05:54] [Server thread/INFO]: This is done because for compat reasons and because forge sometimes breaks badly
[23:05:54] [Server thread/INFO]: This can be turned off in Miapis config.json
[23:05:54] [Server thread/WARN]: Module not found for bow_handle_normal Key - substituting with empty module
[23:05:54] [Server thread/WARN]: Module not found for bow_arms_normal Key - substituting with empty module
[23:05:54] [Server thread/WARN]: Module not found for bow_string_normal Key - substituting with empty module
[23:05:54] [Server thread/WARN]: ItemModule is null?
[23:05:54] [Server thread/INFO]: Loaded 41 Synergies
[23:05:54] [Server thread/INFO]: Loaded 1 Injectors/Property Substitutors
[23:05:54] [Server thread/INFO]: Loaded 63 Modules
[23:05:54] [Server thread/INFO]: Found 56 Enchantments
[23:05:54] [Server thread/INFO]: Loaded 313 Skins
[23:05:54] [Server thread/INFO]: Loaded 31 Modular Converters
[23:05:54] [Server thread/INFO]: Loaded 114 Materials
[23:05:54] [Server thread/INFO]: Changing view distance to 12, from 10
[23:05:54] [Server thread/INFO]: Changing simulation distance to 12, from 0
[23:05:55] [Server thread/INFO]: Provismet[local:E:db50ad0e] logged in with entity id 94 at (12.784302311374871, -60.0, 20.016032050795875)
[23:05:55] [Server thread/INFO]: Provismet joined the game
[23:05:56] [Render thread/WARN]: Module not found for bow_handle_normal Key - substituting with empty module
[23:05:56] [Render thread/WARN]: Module not found for bow_arms_normal Key - substituting with empty module
[23:05:56] [Render thread/WARN]: Module not found for bow_string_normal Key - substituting with empty module
[23:05:56] [Render thread/WARN]: ItemModule is null?
[23:05:56] [Render thread/INFO]: Loaded 41 Synergies
[23:05:56] [Render thread/INFO]: Loaded 1 Injectors/Property Substitutors
[23:05:56] [Render thread/INFO]: Loaded 63 Modules
[23:05:56] [Render thread/INFO]: Found 56 Enchantments
[23:05:56] [Render thread/INFO]: Loaded 313 Skins
[23:05:56] [Render thread/INFO]: Loaded 31 Modular Converters
[23:05:56] [Render thread/INFO]: Loaded 114 Materials
[23:05:56] [Render thread/INFO]: Client load took 1316.0062 ms
[23:05:56] [Render thread/INFO]: Loaded 155 advancements
[23:05:56] [Render thread/INFO]: Created: 256x9x0 miapi:textures/atlas/materials.png-atlas
[23:05:56] [Render thread/INFO]: Created material atlas with size 256x9
[23:06:06] [Thread-9/WARN]: Couldnt retrieve Miapi Permissions
[23:06:06] [Thread-10/WARN]: Couldnt retrieve Miapi Permissions
[23:06:13] [Server thread/INFO]: [Provismet: Summoned new Vindicator]
[23:06:13] [Render thread/INFO]: [System] [CHAT] Summoned new Vindicator
[23:06:17] [Render thread/ERROR]: Unreported exception thrown!
java.util.ConcurrentModificationException: null
	at java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:756) ~[?:?]
	at java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:788) ~[?:?]
	at java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:786) ~[?:?]
	at java.util.Iterator.forEachRemaining(Iterator.java:133) ~[?:?]
	at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845) ~[?:?]
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?]
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
	at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?]
	at com.redpxnda.nucleus.util.PriorityMap.sort(PriorityMap.java:40) ~[nucleus-1.1.2-a0d0def63847af19.jar:?]
	at com.redpxnda.nucleus.util.PriorityMap.sortIfUnsorted(PriorityMap.java:46) ~[nucleus-1.1.2-a0d0def63847af19.jar:?]
	at com.redpxnda.nucleus.event.PrioritizedEvent$Impl.update(PrioritizedEvent.java:234) ~[nucleus-1.1.2-a0d0def63847af19.jar:?]
	at com.redpxnda.nucleus.event.PrioritizedEvent$Impl.invoker(PrioritizedEvent.java:209) ~[nucleus-1.1.2-a0d0def63847af19.jar:?]
	at net.minecraft.class_1309.handler$zpd000$miapi$damageEvent(class_1309.java:7647) ~[client-intermediary.jar:?]
	at net.minecraft.class_1309.method_5643(class_1309.java) ~[client-intermediary.jar:?]
	at net.minecraft.class_3763.method_5643(class_3763.java:295) ~[client-intermediary.jar:?]
	at net.minecraft.class_1657.method_7324(class_1657.java:1263) ~[client-intermediary.jar:?]
	at net.minecraft.class_636.method_2918(class_636.java:412) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1536(class_310.java:1729) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1508(class_310.java:2049) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1574(class_310.java:1883) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1523(class_310.java:1181) ~[client-intermediary.jar:?]
	at net.minecraft.class_310.method_1514(class_310.java:802) ~[client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:250) ~[1.20.1-0.16.3.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) ~[fabric-loader-0.16.3.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.16.3.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.16.3.jar:?]
[23:06:17] [Server thread/INFO]: Stopping server
[23:06:17] [Server thread/INFO]: Saving players
[23:06:17] [Server thread/INFO]: Provismet lost connection: Disconnected
[23:06:17] [Server thread/INFO]: Provismet left the game
[23:06:17] [Server thread/INFO]: Stopping singleplayer server as player logged out
[23:06:17] [Server thread/INFO]: Saving worlds
[23:06:18] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:overworld
[23:06:18] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_nether
[23:06:18] [Server thread/INFO]: Saving chunks for level 'ServerLevel[New World]'/minecraft:the_end
[23:06:18] [Server thread/INFO]: ThreadedAnvilChunkStorage (New World): All chunks are saved
[23:06:18] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM-1): All chunks are saved
[23:06:18] [Server thread/INFO]: ThreadedAnvilChunkStorage (DIM1): All chunks are saved
[23:06:18] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
crash log 
---- Minecraft Crash Report ----
// Hey, that tickles! Hehehe!

Time: 2024-09-12 23:06:18
Description: Unexpected error

java.util.ConcurrentModificationException
	at java.base/java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:756)
	at java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:788)
	at java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:786)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at com.redpxnda.nucleus.util.PriorityMap.sort(PriorityMap.java:40)
	at com.redpxnda.nucleus.util.PriorityMap.sortIfUnsorted(PriorityMap.java:46)
	at com.redpxnda.nucleus.event.PrioritizedEvent$Impl.update(PrioritizedEvent.java:234)
	at com.redpxnda.nucleus.event.PrioritizedEvent$Impl.invoker(PrioritizedEvent.java:209)
	at net.minecraft.class_1309.handler$zpd000$miapi$damageEvent(class_1309.java:7647)
	at net.minecraft.class_1309.method_5643(class_1309.java)
	at net.minecraft.class_3763.method_5643(class_3763.java:295)
	at net.minecraft.class_1657.method_7324(class_1657.java:1263)
	at net.minecraft.class_636.method_2918(class_636.java:412)
	at net.minecraft.class_310.method_1536(class_310.java:1729)
	at net.minecraft.class_310.method_1508(class_310.java:2049)
	at net.minecraft.class_310.method_1574(class_310.java:1883)
	at net.minecraft.class_310.method_1523(class_310.java:1181)
	at net.minecraft.class_310.method_1514(class_310.java:802)
	at net.minecraft.client.main.Main.main(Main.java:250)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
	at java.base/java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:756)
	at java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:788)
	at java.base/java.util.LinkedHashMap$LinkedEntryIterator.next(LinkedHashMap.java:786)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at com.redpxnda.nucleus.util.PriorityMap.sort(PriorityMap.java:40)
	at com.redpxnda.nucleus.util.PriorityMap.sortIfUnsorted(PriorityMap.java:46)
	at com.redpxnda.nucleus.event.PrioritizedEvent$Impl.update(PrioritizedEvent.java:234)
	at com.redpxnda.nucleus.event.PrioritizedEvent$Impl.invoker(PrioritizedEvent.java:209)
	at net.minecraft.class_1309.handler$zpd000$miapi$damageEvent(class_1309.java:7647)
	at net.minecraft.class_1309.method_5643(class_1309.java)
	at net.minecraft.class_3763.method_5643(class_3763.java:295)
	at net.minecraft.class_1657.method_7324(class_1657.java:1263)
	at net.minecraft.class_636.method_2918(class_636.java:412)
	at net.minecraft.class_310.method_1536(class_310.java:1729)
	at net.minecraft.class_310.method_1508(class_310.java:2049)

-- Affected level --
Details:
	All players: 1 total; [class_746['{MINECRAFT_USERNAME}'/94, l='ClientLevel', x=-9.90, y=-58.98, z=3.98]]
	Chunk stats: 961, 609
	Level dimension: minecraft:overworld
	Level spawn location: World: (0,-60,0), Section: (at 0,4,0 in 0,-4,0; chunk contains blocks 0,-64,0 to 15,319,15), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511)
	Level time: 34222 game time, 34222 day time
	Server brand: fabric
	Server type: Integrated singleplayer server
Stacktrace:
	at net.minecraft.class_638.method_8538(class_638.java:458)
	at net.minecraft.class_310.method_1587(class_310.java:2406)
	at net.minecraft.class_310.method_1514(class_310.java:826)
	at net.minecraft.client.main.Main.main(Main.java:250)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

-- Last reload --
Details:
	Reload number: 1
	Reload reason: initial
	Finished: Yes
	Packs: vanilla, fabric

-- System Details --
Details:
	Minecraft Version: 1.20.1
	Minecraft Version ID: 1.20.1
	Operating System: Windows 10 (amd64) version 10.0
	Java Version: 17.0.3, Eclipse Adoptium
	Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Eclipse Adoptium
	Memory: 653465200 bytes (623 MiB) / 1310720000 bytes (1250 MiB) up to 2147483648 bytes (2048 MiB)
	CPUs: 8
	Processor Vendor: GenuineIntel
	Processor Name: Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
	Identifier: Intel64 Family 6 Model 158 Stepping 9
	Microarchitecture: Kaby Lake
	Frequency (GHz): 4.20
	Number of physical packages: 1
	Number of physical CPUs: 4
	Number of logical CPUs: 8
	Graphics card #0 name: NVIDIA GeForce RTX 3060
	Graphics card #0 vendor: NVIDIA (0x10de)
	Graphics card #0 VRAM (MB): 4095.00
	Graphics card #0 deviceId: 0x2487
	Graphics card #0 versionInfo: DriverVersion=32.0.15.6094
	Memory slot #0 capacity (MB): 8192.00
	Memory slot #0 clockSpeed (GHz): 2.13
	Memory slot #0 type: DDR4
	Memory slot #1 capacity (MB): 8192.00
	Memory slot #1 clockSpeed (GHz): 2.13
	Memory slot #1 type: DDR4
	Memory slot #2 capacity (MB): 8192.00
	Memory slot #2 clockSpeed (GHz): 2.13
	Memory slot #2 type: DDR4
	Memory slot #3 capacity (MB): 8192.00
	Memory slot #3 clockSpeed (GHz): 2.13
	Memory slot #3 type: DDR4
	Virtual memory max (MB): 37565.37
	Virtual memory used (MB): 17427.78
	Swap memory total (MB): 4864.00
	Swap memory used (MB): 75.04
	JVM Flags: 2 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx2048M
	Fabric Mods: 
		architectury: Architectury 9.2.14
		arsenal: Truly Modular: Arsenal 1.10
		cloth-config: Cloth Config v11 11.1.118
			cloth-basic-math: cloth-basic-math 0.6.1
		combat-plus-core: Combat+ Core 1.1.0+1.20.1
			lilylib: LilyLib 1.1.3+1.20
			mm: Manningham Mills 2.3
		dualswords: Dual Swords 1.1.2+1.20.1
		fabric-api: Fabric API 0.92.2+1.20.1
			fabric-api-base: Fabric API Base 0.4.31+1802ada577
			fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.36+1802ada577
			fabric-biome-api-v1: Fabric Biome API (v1) 13.0.13+1802ada577
			fabric-block-api-v1: Fabric Block API (v1) 1.0.11+1802ada577
			fabric-block-view-api-v2: Fabric BlockView API (v2) 1.0.1+1802ada577
			fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.41+1802ada577
			fabric-client-tags-api-v1: Fabric Client Tags 1.1.2+1802ada577
			fabric-command-api-v1: Fabric Command API (v1) 1.2.34+f71b366f77
			fabric-command-api-v2: Fabric Command API (v2) 2.2.13+1802ada577
			fabric-commands-v0: Fabric Commands (v0) 0.2.51+df3654b377
			fabric-containers-v0: Fabric Containers (v0) 0.1.64+df3654b377
			fabric-content-registries-v0: Fabric Content Registries (v0) 4.0.11+1802ada577
			fabric-convention-tags-v1: Fabric Convention Tags 1.5.5+1802ada577
			fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.19+1802ada577
			fabric-data-attachment-api-v1: Fabric Data Attachment API (v1) 1.0.0+de0fd6d177
			fabric-data-generation-api-v1: Fabric Data Generation API (v1) 12.3.4+1802ada577
			fabric-dimensions-v1: Fabric Dimensions API (v1) 2.1.54+1802ada577
			fabric-entity-events-v1: Fabric Entity Events (v1) 1.6.0+1c78457f77
			fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.6.2+1802ada577
			fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.63+df3654b377
			fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.40+1802ada577
			fabric-item-api-v1: Fabric Item API (v1) 2.1.28+1802ada577
			fabric-item-group-api-v1: Fabric Item Group API (v1) 4.0.12+1802ada577
			fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.37+1802ada577
			fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.35+df3654b377
			fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.2.22+1802ada577
			fabric-loot-api-v2: Fabric Loot API (v2) 1.2.1+1802ada577
			fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.1.45+9e7660c677
			fabric-message-api-v1: Fabric Message API (v1) 5.1.9+1802ada577
			fabric-mining-level-api-v1: Fabric Mining Level API (v1) 2.1.50+1802ada577
			fabric-model-loading-api-v1: Fabric Model Loading API (v1) 1.0.3+1802ada577
			fabric-models-v0: Fabric Models (v0) 0.4.2+9386d8a777
			fabric-networking-api-v1: Fabric Networking API (v1) 1.3.11+1802ada577
			fabric-networking-v0: Fabric Networking (v0) 0.3.51+df3654b377
			fabric-object-builder-api-v1: Fabric Object Builder API (v1) 11.1.3+1802ada577
			fabric-particles-v1: Fabric Particles (v1) 1.1.2+1802ada577
			fabric-recipe-api-v1: Fabric Recipe API (v1) 1.0.21+1802ada577
			fabric-registry-sync-v0: Fabric Registry Sync (v0) 2.3.3+1802ada577
			fabric-renderer-api-v1: Fabric Renderer API (v1) 3.2.1+1802ada577
			fabric-renderer-indigo: Fabric Renderer - Indigo 1.5.2+85287f9f77
			fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.46+df3654b377
			fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.37+92a0d36777
			fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.0.28+1802ada577
			fabric-rendering-v0: Fabric Rendering (v0) 1.1.49+df3654b377
			fabric-rendering-v1: Fabric Rendering (v1) 3.0.8+1802ada577
			fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 2.3.8+1802ada577
			fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.11.10+1802ada577
			fabric-screen-api-v1: Fabric Screen API (v1) 2.0.8+1802ada577
			fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.3.30+1802ada577
			fabric-sound-api-v1: Fabric Sound API (v1) 1.0.13+1802ada577
			fabric-transfer-api-v1: Fabric Transfer API (v1) 3.3.5+8dd72ea377
			fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 4.3.1+1802ada577
		fabricloader: Fabric Loader 0.16.3
			mixinextras: MixinExtras 0.4.1
		java: OpenJDK 64-Bit Server VM 17
		miapi: Truly Modular 1.1.31
			com_ezylang_evalex: EvalEx 3.2.0
			nucleus: Nucleus (Core) 1.1.2
			nucleus_codec: Nucleus (Codec) 1.1.4
			nucleus_config: Nucleus (Config) 1.1.5
			nucleus_facet: Nucleus (Facet) 1.0.0
			nucleus_pose: Nucleus (Pose) 1.0.0
			reach-entity-attributes: Reach Entity Attributes 2.4.0
		minecraft: Minecraft 1.20.1
		modmenu: Mod Menu 7.2.2
		provihealth: Provi's Health Bars 1.2.4+1.20.1
	Launched Version: 1.20.1
	Backend library: LWJGL version 3.3.1 SNAPSHOT
	Backend API: NVIDIA GeForce RTX 3060/PCIe/SSE2 GL version 3.2.0 NVIDIA 560.94, NVIDIA Corporation
	Window size: 1920x1017
	GL Caps: Using framebuffer using OpenGL 3.2
	GL debug messages: 
	Using VBOs: Yes
	Is Modded: Definitely; Client brand changed to 'fabric'; Server brand changed to 'fabric'
	Type: Integrated Server (map_client.txt)
	Graphics mode: fancy
	Resource Packs: fabric
	Current Language: en_us
	CPU: 8x Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
	Server Running: true
	Player Count: 1 / 8; [class_3222['{MINECRAFT_USERNAME}'/94, l='ServerLevel[New World]', x=-9.90, y=-58.98, z=3.98]]
	Data Packs: vanilla, fabric
	Enabled Feature Flags: minecraft:vanilla
	World Generation: Stable

Additional context Crash was found during final integration testing of the solution to this issue.

This is understandably difficult to resolve without reworking the damage events away from Nucleus. As such, this issue exists mostly to just serve as a record that this crash is possible with the current version, in case it comes up again in future.

Provismet avatar Sep 15 '24 16:09 Provismet

quick question, did this happen shortly after using /reload or joining the world?

Smartin-b avatar Sep 15 '24 16:09 Smartin-b

Yes this happened soon after joining the world. I loaded in and within the first few seconds attacked a mob.
Based on my log, it was about 23 seconds after joining the world. Subsequent attempts had similar timing without issue.

Provismet avatar Sep 16 '24 00:09 Provismet