actions-flake8 icon indicating copy to clipboard operation
actions-flake8 copied to clipboard

feature request: annotate warnings diff only

Open eivindjahren opened this issue 3 years ago • 2 comments

It is possible to run the action on only those files that have changes in the PR via:

- uses: actions/checkout@v2
  with:
    fetch-depth: -1
- name: Setup Python
  uses: actions/setup-python@v2
  with:
    python-version: 3.9
- id: find_changed_files
  run: echo ::set-output name=changed_files::$(git diff --name-only ${{github.sha}} ${{github.event.pull_request.base.sha}} | tr ' ' '\n' | grep .py | tr '\n' ' ')
- uses: TrueBrain/actions-flake8@v2
  with:
    plugins: flake8-docstrings dlint flake8-bugbear flake8-simplify flake8-debugger flake8-print flake8-pep3101
    only_warn: 1
    extra_arguments: "${{steps.find_changed_files.outputs.changed_files}}"

It would be nice if this was supported directly (although, just documenting would be good also). Also it would be nice if warnings could be shown only for changed files while errors are shown for all files. One simple way of doing so is to run flake8 twice, a much more difficult way of getting this done is to skip the changed files in the regex.

eivindjahren avatar Jul 23 '22 17:07 eivindjahren

Totally agree with you @eivindjahren ! And thanks a lot for your code :)

r-ichard avatar Aug 26 '22 15:08 r-ichard

Oops, sorry, keep forgetting to reply to you :(

I would appreciate a PR that adds documentation about these kind of things. Just in the README as far as I am concerned, under a new topic like Advanced use-case or something. If you wouldn't mind, I would appreciate that!

I am not going to integrate support for it, as I strongly believe an action should do one thing, and one thing well. Covering all use-cases is impossible, and exactly the chain of actions you do is what you want :) So if it is flake8 related, it can go in this action, but if it is git related, it shouldn't :)

TrueBrain avatar Sep 03 '22 08:09 TrueBrain