aowow icon indicating copy to clipboard operation
aowow copied to clipboard

Add missing zones to enus

Open jackpoz opened this issue 5 years ago • 5 comments

Include the zones retrieved with this query (which might not be correct but it adds a lot of zones):

SELECT CONCAT(LPAD(id, 4, " "), ": '", REPLACE(name_loc0, '\'', '\\\''), "',") FROM aowow.aowow_zones;

Fixes #227

jackpoz avatar Dec 31 '20 19:12 jackpoz

@Sarjuuk could you take a look at this ?

jackpoz avatar Jan 02 '21 13:01 jackpoz

Refering to #227, this doesn't fix the real problem that the assigned zone is wrong. You just give a name to the wrong zone.

you might argue future-proofing the js variables for custom Quest zoneOrSort but even then this PR only provides locales to the frontend static/js/locale_xxXX.js) in 1 out of 6 locales and none to the backend localization/locale_xxXX.php

Sarjuuk avatar Jan 03 '21 17:01 Sarjuuk

well, what about https://tcubuntu.northeurope.cloudapp.azure.com/aowow/?zone=2918 ? is that wrong zone too ? or is it missing the zone name only ?

jackpoz avatar Jan 03 '21 19:01 jackpoz

those were instanced until wotlk, when they became part of the open world. (no idea why there are still NPCs spawned inside)

areaTable.dbc id: 2918 => mapId: 449
map.dbc id: 449 => name_loc0 => AlliancePVPBarracks

Sarjuuk avatar Jan 03 '21 20:01 Sarjuuk

it sounds good if you want to close this PR, but please reopen https://github.com/Sarjuuk/aowow/issues/227 . Let me know if there is something to do to fix it (I guess you have the same issue locally or ?)

jackpoz avatar Jan 03 '21 20:01 jackpoz