[3.3.5] Summoning Stones

[Treeston]

3.3.5 c5549ac

Right, can't believe there isn't an issue for this one yet.

Summoning stones on TC aren't retail like. On retail there are no cast times, just the channel (and the channel bar is hidden, anecdotally).

[Goatform]

Not tested:

            case 23598: // Meeting Stone Summon
                spellInfo->AttributesEx3 |= SPELL_ATTR3_DONT_DISPLAY_CHANNEL_BAR;
                spellInfo->AttributesEx5 |= SPELL_ATTR5_HIDE_DURATION;
                spellInfo->AttributesEx &= ~SPELL_ATTR1_CHANNEL_DISPLAY_SPELL_NAME;
                spellInfo->Attributes |= SPELL_ATTR0_NOT_SHAPESHIFT;
                break;

[ariel-]

23598 is the proper spell (triggers 59782) however in TC 59782 is used directly.

There seems to be a mishandling of triggered spells which are channeled and have a cast time (like 59782 - Summoning Stone Effect is). In sniffs the PendingCast flag is set meaning the spell should be casted triggered.

However after changing it to a triggered cast, the cast bar disappears but the summoning GameObject appears 5 seconds later (like if the cast continued, hidden)

So it seems like another issue needs to be fixed first (channeled spells with cast time should not have cast time when triggered)

EDIT: Actually they seem to have a cast time of 1 sec:

ServerToClient: SMSG_SPELL_GO (0x0132) Length: 33 ConnIdx: 0 Time: 03/04/2010 18:54:24.000 Number: 120253
Caster GUID: 
Caster Unit GUID: 
Cast Count: 0
Spell ID: 23598 (23598)
Cast Flags: PendingCast, Unknown2, Unknown3, Unknown7, Unknown8 (781)
Time: 713514573
Hit Count: 0
Miss Count: 0
Target Flags: Self (0)

ServerToClient: MSG_CHANNEL_START (0x0139) Length: 15 ConnIdx: 0 Time: 03/04/2010 18:54:25.000 Number: 120258
GUID: Full: 
Spell ID: 59782 (59782)
Duration: 120000

[Shauren]

In sniffs the PendingCast flag is set meaning the spell should be casted triggered

Nope. This is false.

[ariel-]

Only way to have TC send PendingCast flag is that, or spell having "Can cast while casting" flag

[Aokromes]

this issue is still valid?

[CraftedRO]

11d9a4e2518a seems still valid

https://user-images.githubusercontent.com/24683355/114284375-18df0280-9a58-11eb-9335-f2eb07c9b127.mp4

[CraftedRO]

As it was already noticed in the above comment, 59782 this spell is most likely used wrong here https://github.com/TrinityCore/TrinityCore/blob/93ab97a37c769cfbc0c5d3aea44aee0e3cd877bc/src/server/game/Entities/GameObject/GameObject.cpp#L2070 and shoud be used this one Meeting Stone Summon entry instead, but there might also need some other changes because it will give "You have no target." error even if you have one.