angular-application-insights icon indicating copy to clipboard operation
angular-application-insights copied to clipboard

upgrade to AI v2

Open goenning opened this issue 6 years ago • 8 comments

Now that AI v2 is released, can we upgrade this library to use the latest?

I'm happy to provide a PR, because I really need a feature that is in v2.

goenning avatar May 23 '19 08:05 goenning

Oh I didn’t know it was officially released out of alpha/beta! Yeah if it isn’t too big of change and you want to give it a shot that’d be amazing!! 🙌🙌

If not I can try to take a crack at it but I’m away next week so might be tough to squeeze it in.

Any help is always super appreciated! ❤️

MarkPieszak avatar May 23 '19 15:05 MarkPieszak

I was looking at it now and it seems like v2 is a big rewrite compared to v1

I'll give it a try over the weekend and see how far I can get :)

goenning avatar May 23 '19 20:05 goenning

You rock! @goenning Let me know if you need me to look at anything :+1:

MarkPieszak avatar May 28 '19 20:05 MarkPieszak

Hey Mark, I'm sorry but I didn't get much done last weekend. I'll be off for 2 weeks now, will try again when I'm back. I also couldn't find any reference to v2 on official docs, so I guess it's not that public yet. Feel free to have a look too if you wish.

goenning avatar May 29 '19 07:05 goenning

Is this lib still in active development? Or should we use angular-application-insights-v2 instead?

ntziolis avatar Feb 28 '20 16:02 ntziolis

@MarkPieszak same question as @ntziolis above, is this enhancement still on hold?

michaelmarcuccio avatar Apr 07 '20 17:04 michaelmarcuccio

@MarkPieszak We really like your lib it's fine if you are too busy to update ;) Just give the community a hint what should we do ;) should we wait, contribute or just move on? :)

pkarny avatar Aug 25 '20 14:08 pkarny

Just a heads up: I tried updating this package to appinsights v2 long ago, but faced too may breaking changes. Given that we only needed a thin angular compatibility layer, I ended up with this new package: https://github.com/goenning/ng-appinsights

It might not have all features supported by angular-application-insights, but some people might find it useful.

goenning avatar Aug 25 '20 15:08 goenning