no clickable images on https://trilarion.github.io/opensourcegames/games/top50.html
good morning i found a "bug" basically no clickable images. some clickable images doesn't work. and some are broken
1.Mindustry click on image 404 File not found link https://mindustrygame.github.io/images/1.png 2.CnC Remastered Collection no images 3.osu! no click on image 4.OpenRA no click on image 5.OpenRCT2 click on image work 6.2048 click on image work 7.OpenDiablo2 click on image work 8.Stockfish click on image Error 1011 9.Craft click on image work 10. Cataclysm: Dark Days Ahead click on image work 11. WarriorJS no image 12. Devilution no click on image 13. Citybound click on image work 14. Unciv click on image does not work 404: Not Found on second and third img not found (bucket 403) 15. DevilutionX click on image work 16. A Dark Room no image 17. OpenTTD click on image work 18. Endless Sky click on image work 19. The Battle for Wesnoth click on images work 20. RuneLite click on image 1 and 2 doesnt work but 3 work 21. OpenLara no click on images 22. The Powder Toy click on images 23. SuperTuxKart if you click on the image it will transport you to github repo 24. zelda3 no img 25. VCMI click on images work 26. CorsixTH cant click on 1 image but work on second one 27. Pixel Dungeon click on images work 28. Shattered Pixel Dungeon no clickable img 29. SpaceCadetPinball no img 30. Warzone 2100 firs image is not clickable and second and thrid are 31. Serious Engine no img 32. sandspiel clickable images 33. OpenGOAL no img 34. NetHack clickable img 35. 0 A.D. clickable img 36. Ship of Harkinian no img 37. Thrive 1,2 img does not work but 3 work 38. Julius img work 39. Daggerfall Unity img work 40. Free Heroes 2 clickable imgaes 41. Marble Marcher images work 42. SuperTux clickable images 43. Overgrowth no img 44. Teeworlds clickable images 45. Dungeon Crawl Stone Soup img work 46. Hextris img not work 47. GZDoom images work 48. ZDoom clickable images work 49. freeablo no clickable img 50. Veloren no clickable images
tested on firefox august 7
Thanks for the report. I'll look into it.
Thanks for the report. I'll look into it.
thanks you for your time sir
I looked at it and there are some problems, which can be kind of fixed.
I linked to original versions, but only if they were better resolved (i.e. had much more pixels). People might wonder why some of the images have no links. That would be those without original images with a high resolution. To clarify this. There should be a tooltip (alt tag explaining this).
Second, these links tend to get broken. Many of them are already. In my broken link search I did not include them. I should include them in the broken link search script and either replace them or remove them.
For these cases here with the help of the list by stuffbymax I manually replaced or removed them. They will appear with the next Github push.
Thanks again for reporting.
hello i didn't really help you i just informed about the problem
hello i didn't really help you i just informed about the problem
And that helped because now I know about it. :)
is there any way that i will help more?
If you want, I could think of the best ways to help.
- I could run the script that checks for broken external links and could upload the results here in an issue, where you could check some of these and report on them (something like: moved to another location, not existing anymore but available on internetarchive, found a replacement link). You can run the script too if you want. I do that approximately once per year and find approximately 300 broken links many of which can be salvaged. It would be time again.
- You could complete information. Frequently, fields are missing like where to download the game or which OS are supported. You could go through the list and for those that do not feature this information, add it. You could also add keywords (but I don't want it too fine-grained).
- You could produce screenshots of games that don't have them. Either look at their homepages (sometimes they have a gallery) or run the game and make screenshots yourself.
- Check last active information. If the last source code change was less than a year ago, I mark it as active, otherwise as inactive. However, this often changes, some projects become inactive, others become active again.
- Whatever you can think of...
ok
@Trilarion can i edit the code directly because it would be faster
Sure. If you are familiar with the git-pull request workflow, then please clone this repository, make changes and commit them, then start a pull request.
oh is in python is there way to unpackage it to html?
The HTML rendered version is in docs https://github.com/Trilarion/opensourcegames/tree/master/docs
But the underlying source is in text with some formatting elements (markdown) in https://github.com/Trilarion/opensourcegames/tree/master/entries in the *.md files there. The images are specified in https://github.com/Trilarion/opensourcegames/blob/master/entries/screenshots/README.md These files are what I edit and then convert to HTML with a Python script. This script is https://github.com/Trilarion/opensourcegames/blob/master/code/html/generate_static_website.py and if you are experienced with Python you can run it, but I don't recommend it.
For contributing I don't care in which form people submit things. Contributors can report on content changes in any way they want.
- You can fork and change the source content files (*.md) in folder entries
- You can fork and change the HTML in folder doc
- You can just look at the HTML in https://trilarion.github.io/opensourcegames/ and report changes in an issue here with text
Whatever works best for you.
thanks you good sir /madam
hi i want let you know that i started fixing the html