ivy icon indicating copy to clipboard operation
ivy copied to clipboard

Logical and

Open samthakur587 opened this issue 2 years ago • 1 comments

Close #17734

samthakur587 avatar Jun 27 '23 13:06 samthakur587

hey @hello-fri-end i made all changes that are required. and all test are passing in my local. now you can check is there any changes required.

Now its ready to merge.

thank you

samthakur587 avatar Jun 29 '23 07:06 samthakur587

hey @hello-fri-end i made all changes that are required. and all test are passing in my local. now you can check is there any changes required.

Now its ready to merge.

thank you

Hey @samthakur587 ! It looks like you are trying to add both the frontend function and the instance method for logical_and in this PR. Currently, there's an open task for adding logical_and as a frontend function unassigned in this ToDo list (https://github.com/unifyai/ivy/issues/15036). Can you please assign that to yourself so we can link it to this PR? Also, In the future, it's better to open separate PRs for different tasks. Feel free to request another review when you are done. Thanks :)

hello-fri-end avatar Jul 03 '23 07:07 hello-fri-end

hey @hello-fri-end now i assign the subtask to me and solved the merge. i implemented just to call the method from paddle frontend instande of calling from ivy frontend. i had never seen that it is a different sub task.

thank you

samthakur587 avatar Jul 03 '23 07:07 samthakur587

hey @hello-fri-end now i assign the subtask to me and solved the merge. i implemented just to call the method from paddle frontend instande of calling from ivy frontend. i had never seen that it is a different sub task.

thank you

LGTM! Thanks for the contribution :rocket:

hello-fri-end avatar Jul 03 '23 10:07 hello-fri-end