nativelink icon indicating copy to clipboard operation
nativelink copied to clipboard

Fix typos in code comments

Open boldpulse opened this issue 1 year ago • 1 comments

Description

Recently, I found out that there were 2 typos remaining in this project.

  1. Here, my should be may.

https://github.com/TraceMachina/nativelink/blob/d37bd90a314890fe901235e0432d263faa66d221/deployment-examples/docker-compose/Dockerfile#L21

  1. Here, the code comments for simple_cache_test.sh and simple_prometheus_test.sh are the same currently. For simple_prometheus_test.sh, the comment should be changed.

https://github.com/TraceMachina/nativelink/blob/d37bd90a314890fe901235e0432d263faa66d221/integration_tests/simple_cache_test.sh#L16

https://github.com/TraceMachina/nativelink/blob/d37bd90a314890fe901235e0432d263faa66d221/integration_tests/simple_prometheus_test.sh#L16

Fixes #1189

Type of change

Please delete options that aren't relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] This change requires a documentation update

Checklist

  • [x] Updated documentation if needed
  • [x] bazel test //... passes locally
  • [x] PR is contained in a single commit, using git amend see some docs

This change is Reviewable

boldpulse avatar Jul 24 '24 07:07 boldpulse

Just caught simple issues. cc: @allada, @MarcusSorealheis

Waiting for reviews on my previous submitted issues and wanna work on more issues. :)

boldpulse avatar Jul 24 '24 08:07 boldpulse

Rebased. cc: @aaronmondal, @MarcusSorealheis

boldpulse avatar Aug 08 '24 13:08 boldpulse

Hope you to merge this. cc: @allada, @MarcusSorealheis, @aaronmondal

boldpulse avatar Aug 09 '24 09:08 boldpulse