nativelink icon indicating copy to clipboard operation
nativelink copied to clipboard

Fix:Prevent CAS and AC from using the same store and add integration …

Open RickDeb2004 opened this issue 1 year ago • 5 comments

…test

Description

This commit includes changes to prevent CAS and AC from being configured to use the same store, which could cause conflicts. The conflict check logic has been optimized using a hashmap for better performance. Additionally, an integration test script has been added to verify the conflict detection functionality.

Fixes # (issue) issue: #768

Type of change

Please delete options that aren't relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • [x] This change requires a documentation update

How Has This Been Tested?

Verified the service logs for correct error messages when CAS and AC are configured with the same store. Created and executed an integration test script simple_store_conflict_test.sh to automate the verification process.

Checklist

  • [ ] Updated documentation if needed
  • [ yes] Tests added/amended
  • [ ] bazel test //... passes locally
  • [yes ] PR is contained in a single commit, using git amend see some docs

This change is Reviewable

RickDeb2004 avatar Jul 19 '24 19:07 RickDeb2004

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 19 '24 19:07 CLAassistant

@RickDeb2004 You need to sign the commit and fix the tests failing. I can help but ideally you should handle this one.

MarcusSorealheis avatar Jul 21 '24 17:07 MarcusSorealheis

Let me know in Slack if you want a hand.

MarcusSorealheis avatar Jul 21 '24 17:07 MarcusSorealheis

@RickDeb2004 You need to sign the commit and fix the tests failing. I can help but ideally you should handle this one.

Sure sir , I will try to fix everything by tonight

RickDeb2004 avatar Jul 22 '24 05:07 RickDeb2004

Any update on this? If not I want to put this ticket back into the queue.

Thanks :-)

allada avatar Aug 16 '24 18:08 allada