python-sdk icon indicating copy to clipboard operation
python-sdk copied to clipboard

Update aiohttp constraints

Open No767 opened this issue 2 years ago • 10 comments

With aiohttp releasing 3.9.0, which supports 3.12, we need to update the current constraints

Fixes #

Proposed Changes

No767 avatar Oct 23 '23 06:10 No767

ping @Esmeray6

No767 avatar Oct 24 '23 23:10 No767

ping @Esmeray6

Ping someone from the top.gg team (if someone actually cares to look into these 🙃).

I don't maintain the library anymore. Or did you just want a second pair of eyes?

Esmeray6 avatar Oct 24 '23 23:10 Esmeray6

ping @Esmeray6

Ping someone from the top.gg team (if someone actually cares to look into these 🙃).

I don't maintain the library anymore. Or did you just want a second pair of eyes?

I'll take care of maintaining the library if you want me to do so. I'll contact the topgg team if they are able to merge this pr

No767 avatar Oct 24 '23 23:10 No767

If nothing has changed by now, you'll have to run your changes through someone from the team (no collaborator permissions, you just create PRs and the team merges them).

My wonder is whether anyone from the team will bother with this library after... 3? years of no updates to this repo.

With this said, it's entirely up to you.

Esmeray6 avatar Oct 24 '23 23:10 Esmeray6

If nothing has changed by now, you'll have to run your changes through someone from the team (no collaborator permissions, you just create PRs and the team merges them).

True, but this PR doesn't really have any changes. The updated requirements for aiohttp follow the same exact requirements as discord.py's aiohttp version requirements. I'll try and ask someone on the team if I can help out

No767 avatar Oct 25 '23 01:10 No767

It's more about the fact that maintainers, as far as I recall (3 years ago, give or take), don't have write access to the repositories. So, they're simply stuck with waiting for whoever to review the changes and accept the PRs. Correct me if that's changed at any point after that.

Nevertheless, I'm just ranting off-topic at this point. My apologies.

Esmeray6 avatar Oct 25 '23 11:10 Esmeray6

@No767 Additionally if you still want to maintain this library, I would prefer to be contacted by someone from the staff to transfer ownership of the PyPi package.

Esmeray6 avatar Jan 20 '24 09:01 Esmeray6

@Esmeray6 Sure

No767 avatar Jan 20 '24 18:01 No767

Any update on this?

Esmeray6 avatar Mar 04 '24 04:03 Esmeray6

This PR is overwritten by #74, can be closed if that gets merged.

Esmeray6 avatar Mar 27 '24 10:03 Esmeray6