node-gcm icon indicating copy to clipboard operation
node-gcm copied to clipboard

Supporting delivery_receipt_requested feature

Open Rostyk opened this issue 7 years ago • 4 comments

Is it possible to add the acknowledgement of the message receipt?

Rostyk avatar May 22 '18 13:05 Rostyk

Hi @Rostyk, could you elaborate on what you mean with this issue?

A link or a more elaborate description of the feature would be helpful :smile:

hypesystem avatar May 22 '18 14:05 hypesystem

In the FCM documentation (Receive delivery receipts section) it says:

For Android and Chrome client apps, you can get delivery receipts (sent from FCM to your app server) when a device confirms that it received a message sent by FCM.

So I was wondering if there's a possibility to add delivery_receipt_requested flag so FCM would send a delivery receipt when it receives confirmation that the device received the message.

Rostyk avatar May 22 '18 23:05 Rostyk

Oh, Sorry, I just realized its GCM. Please disregard.

Rostyk avatar May 22 '18 23:05 Rostyk

@Rostyk FCM is the new name for GCM. Unfortunately the name "FCM" is taken for npm libraries. This doesn't mean that we won't support FCM features, though, so let's look at this a bit further :smile:

We can definitely support that new parameter. Would you be interested in making a PR for it? We'll be here to guide you through the required changes.

The primary change is adding the parameter to the list of supported ones in message-options.js

We would also need some tests of the new functionality.

hypesystem avatar May 23 '18 08:05 hypesystem