ToolJet icon indicating copy to clipboard operation
ToolJet copied to clipboard

[refactor]: Invite Users Form icon's to support Dark mode

Open Ayyanaruto opened this issue 1 year ago • 6 comments

GitHub Issue Title: Refactor Invite Users Icon Color Based on Dark/Light Mode

Description: The icon in the Invite Users component within frontend/src/ManagerUsers/InviteUsers.jsx is currently not changing its icon's color to match the current dark or light mode. This inconsistency can lead to a less visually appealing user experience.

Steps to Reproduce:

  1. Navigate to the Invite Users component.
  2. Toggle between dark and light mode.
  3. Observe that the icon's color remains unchanged.

Expected Behavior:

The icon's color should dynamically adjust to match the system's current theme (dark or light).

Additional Notes:

  • Check from localstorage whether app is in darkmode or not and change the color of icon's dynamically based on that Attachments: WhatsApp Image 2024-10-03 at 12 03 57 PM (2)

Ayyanaruto avatar Oct 03 '24 06:10 Ayyanaruto

I would like to take this issue.

On Thu, 3 Oct, 2024, 12:21 pm Ayyan Shaikh, @.***> wrote:

GitHub Issue Title: Refactor Invite Users Icon Color Based on Dark/Light Mode

Description: The icon in the Invite Users component within frontend/src/ManagerUsers/InviteUsers.jsx is currently not changing its icon's color to match the current dark or light mode. This inconsistency can lead to a less visually appealing user experience.

Steps to Reproduce:

  1. Navigate to the Invite Users component.
  2. Toggle between dark and light mode.
  3. Observe that the icon's color remains unchanged.

Expected Behavior:

The icon's color should dynamically adjust to match the system's current theme (dark or light).

Additional Notes:

— Reply to this email directly, view it on GitHub https://github.com/ToolJet/ToolJet/issues/10868, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKUZMYMDYAIXRZWLBHNFLS3ZZTSODAVCNFSM6AAAAABPJECKTKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU3DGMRWGM4DIMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

FurquanAnwer avatar Oct 03 '24 07:10 FurquanAnwer

let me work on this

nsanzimana1 avatar Oct 03 '24 10:10 nsanzimana1

Let me work on this issue. I have good experience working without with Frontend Development especially in React.

RazalBinKabeer avatar Oct 04 '24 12:10 RazalBinKabeer

Hey @Ayyanaruto,

Thank you for opening the issue and taking the time to create a PR for it. 🙌

We really appreciate your effort and contribution!

PriteshKiri avatar Oct 04 '24 17:10 PriteshKiri

@PriteshKiri , i would like to contribute .Could you please assign me this ?

shreyanshgoyal18 avatar Oct 06 '24 16:10 shreyanshgoyal18

Hey @shreyanshgoyal18 , this issue has already been assigned.

Please check out other open issues under the community contribution.

PriteshKiri avatar Oct 07 '24 06:10 PriteshKiri