Tommy Li comments

Results 188 comments of


                                            Tommy Li

[feature] Support PV/PVCs as an alternative to Object Storage for KFP

We have discussed in the past for the Tekton community on how it should implemented. https://github.com/tektoncd/pipeline/issues/4012

feat(backend): Upgrade go version to 1.21

Hi @chensun, it seems like the presubmit-backend-test go binary is 1.20. Do you know how to upgrade it to 1.21? If it's too much work, I can downgrade my current...

feat(backend): Upgrade go version to 1.21

Hi @chensun, I can't reproduce in my cluster on the error `curl: (6) getaddrinfo() thread failed to start` from the command `'/bin/sh -c curl https://dl.google.com/dl/cloudsdk/release/google-cloud-sdk.tar.gz > /tmp/google-cloud-sdk.tar.gz'` in the integration...

feat(backend): Upgrade go version to 1.21

@chensun I reduced the scope of this PR to only update the go version to 1.20 and the relevant dependencies. This passed the test without breaking the setup of the...

feat(backend): Upgrade go version to 1.21

/assign @chensun

feat(backend + SDK): Add backend and SDK support to use Kubernetes FieldPath as env

/assign @connor-mccarthy /assign @chensun

feat(backend + SDK): Add backend and SDK support to use Kubernetes FieldPath as env

Thanks @chensun, I fixed the PR conflicts and it's good to go now.

feat(backend + SDK): Add backend and SDK support to use Kubernetes FieldPath as env

Hi @rimolive, could you help review this PR and leave a lgtm. I have rebased this PR and is good to go, just need someone to double check and lgtm.

feat(Backend + SDK): Update kfp backend and kubernetes sdk to support ConfigMaps as volumes and as env variables

/ok-to-test

feat(Backend + SDK): Update kfp backend and kubernetes sdk to support ConfigMaps as volumes and as env variables

> > Thanks @roytman, the tests are passed now. Are you planning to refactor the two for loops for configmap mount and configmap env into functions? > > Hi @Tomcli...