Tokamak icon indicating copy to clipboard operation
Tokamak copied to clipboard

Change (V/H)Stack implementation from grid to flex

Open Tyler-pollick opened this issue 3 years ago • 1 comments

Completed @SwiftCoderJoe conversion of (V/H)Stack from grid to flex (PR #466).

As @SwiftCoderJoe mentioned in his PR, this change should fix the Spacer issues described in #441.

All relevant tests have been updated. I will circle back around and back fill with more (V/H)Stack tests.

Tyler-pollick avatar Sep 06 '22 19:09 Tyler-pollick

It's interesting to me that this works with the ZStack... I thought I had applied the same changes from grid syntax to flex syntax and then added minimum heights and widths to 0, but either I for some reason never tested it with this configuration or you have something special that I missed! Either way, I'm really glad to see this finally completed and I'm glad we're moving forward on this! Thanks!

As I'm looking at this now, it seems that you're also failing the testMaterial visual test. I'm on my phone and can't currently look at test screenshots, but if someone could post them that would be great.

SwiftCoderJoe avatar Sep 06 '22 19:09 SwiftCoderJoe