TJ-Bot icon indicating copy to clipboard operation
TJ-Bot copied to clipboard

`commands` package should be named `features`

Open interacsion opened this issue 3 years ago • 4 comments

Right now, almost every feature is in the commands package, which makes its name misleading. we should rename it to features, and delete packages like routines, and instead have their classes moved into features.

interacsion avatar Mar 16 '22 18:03 interacsion

The package split right now is a mess. It makes no sense (and is bad) to split on what type it is. We have to split on topic (see moderation for example). Majority of classes like routines are in their respective topic-package instead right now.

The commands package is misnamed (cause we didnt know better back then). It should be renamed to features.

So the correct action is to rename commands to features, delete package routines and similar packages and move everything under their topic-packages (if not already happened).

Zabuzard avatar Mar 16 '22 19:03 Zabuzard

I see. that makes a lot of sense, actually. should I close the issue?

interacsion avatar Mar 16 '22 19:03 interacsion

You can also rename the title and the description to match that instead and then we can make this a feature request.

Zabuzard avatar Mar 17 '22 07:03 Zabuzard

This issue is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days.

github-actions[bot] avatar Apr 17 '22 07:04 github-actions[bot]

(now would be a good time to do this - @Taz03 if ur still interested)

Zabuzard avatar Jan 26 '23 08:01 Zabuzard