Together icon indicating copy to clipboard operation
Together copied to clipboard

Mob hamburger menu

Open funbunch opened this issue 7 months ago • 6 comments

Description

Removed buttons on mobile on the /calendar route and added a hamburger menu.

Type of change

Please select everything applicable. Please, do not delete any lines.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update
  • [ ] This change requires an update to testing

Issue

  • [x] Is this related to a specific issue? If so, please specify: #549

Checklist:

  • [x] This PR is up to date with the main branch, and merge conflicts have been resolved
  • [x] I have executed npm run test and npm run test:e2e and all tests have passed successfully or I have included details within my PR on the failure.
  • [x] I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings

funbunch avatar Sep 03 '25 03:09 funbunch

New mob menu. Screenshot 2025-09-02 at 7 56 32 PM

Screenshot 2025-09-02 at 8 28 45 PM

funbunch avatar Sep 03 '25 03:09 funbunch

been excited for this!

DevinCLane avatar Sep 05 '25 20:09 DevinCLane

Looks great overall.

i noticed that when you click outside the hamburger menu, it doesn't close. I'm going to say let's merge this anyway, and could you create a separate issue just for that, so someone else could take it?

DevinCLane avatar Nov 04 '25 20:11 DevinCLane

@DevinCLane @moses-codes Not sure why this is failing since I did run prettier and nothing was changed.

funbunch avatar Nov 10 '25 22:11 funbunch

hmm not sure, beyond what that error says

DevinCLane avatar Nov 14 '25 19:11 DevinCLane

@DevinCLane Got the formatting errors to pass! However, I see some other tests now fail and require some refactoring. Will continue to work on those next.

funbunch avatar Nov 18 '25 00:11 funbunch