CellPond
CellPond copied to clipboard
multi-squares in multi-squares in ...
Did this a while ago, but wanted to find a neater solution. Didn't find one and forgot to do it so ill just PR it now if you want to use it.
I did:
- #161 But only when the multi-square gets used (brush and rule update) so i could have missed cases. Did it that way because i don't like the way it looks.
- Made multi-squares in multi-squares work with brush and rules on left and right side. This fixes: #163 / #215 and kind of #322 (only fixes that that setup doesn't error in the rule update and not what it does when it errors)
Stuff i am not happy with/ is janky:
- The merge instruction merges m∗n cells. When i want to merge this: ⊞⊟ it isn't m∗n. Because the merge instruction is inplemented by merging next m∗n cells, i just tell it to merge n∗1 cells (6∗1 in the case of ⊞⊟).
- I implemented almost the same thing three times.
-
flattenAndFillDiagramCellsit flattens nested cells and fills the voids. -
addDiagramCellsToLeftListit does the same but for rule gen on the left side. Also it returns what structure the nested cell had. -
addDiagramCellsToRightListit does the same but for rule gen on the right side and it uses the structure to tell when merge/split
-
- Because the rule update needs nested cells, multi-cells have to be flattened every time they get used else where (in the
splitCellToDiagramfunction).
Deploy Preview for keen-boyd-1443aa ready!
| Name | Link |
|---|---|
| Latest commit | ebab6c75d388d113910486660849d44e9d4b59f6 |
| Latest deploy log | https://app.netlify.com/sites/keen-boyd-1443aa/deploys/66dbab0171cf2900088cd5ac |
| Deploy Preview | https://deploy-preview-362--keen-boyd-1443aa.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hey this looks great. i'll pop in some questions slowly over time
and sorry im so slow :)