sqlmesh icon indicating copy to clipboard operation
sqlmesh copied to clipboard

User edits are lost

Open alinamykal opened this issue 1 year ago • 1 comments

Description

When user edits a model in A tab and switch to B tab, user can't see their changes when user came back to A tab.

Steps to Reproduce

  1. User opens several tabs (ex. A and B).
  2. User edit model in A tab.
  3. User switches to B tab.
  4. User came back to A tab and changes were lost. User can't see their changes.

Expected Result When user edit the model. Edits are saved when user switches between different tabs.

Environment Chrome

alinamykal avatar May 22 '24 00:05 alinamykal

+1

I just encountered this exact same issue.

To fix this, it seems the opened tabs need to maintain their "edit state" in an in-browser data store.

An interim fix might be to perform the same logic that is run when a tab is closed, where the user is warned that their edits will be lost. That's really not ideal though. The expectation is that I can modify more than one tab at a time.

jmarch avatar Jun 02 '24 00:06 jmarch

I noticed this morning when using 0.148.0 that this was fixed. It looks like this PR #3587 addresses the issue in release 0.145.0 @mykalmax I think this issue can be closed, right?

MikeWallis42 avatar Jan 29 '25 14:01 MikeWallis42

Verified this issue has been fixed using the latest main UI build as well. Thanks for bumping the thread @MikeWallis42!

georgesittas avatar Jan 29 '25 21:01 georgesittas