PuLID icon indicating copy to clipboard operation
PuLID copied to clipboard

Python <= 3.8 is not supported

Open PRPA1984 opened this issue 1 year ago • 1 comments

According to the README.md, the required Python version is >= 3.7. I think this is wrong, because the used type annotations are available in Python >= 3.9.

Here is an example

def prepare(t5: HFEmbedder, clip: HFEmbedder, img: Tensor, prompt: str) -> dict[str, Tensor]:

Return type should be replaced by Dict with its corresponding "from typing import Dict" import

def prepare(t5: HFEmbedder, clip: HFEmbedder, img: Tensor, prompt: str) -> Dict[str, Tensor]:

PRPA1984 avatar Sep 13 '24 18:09 PRPA1984

Thanks for you suggestion, we change the dependency to Python >= 3.9 now.

ToTheBeginning avatar Sep 14 '24 04:09 ToTheBeginning