tlf icon indicating copy to clipboard operation
tlf copied to clipboard

Add freq to lanentry

Open dl1jbe opened this issue 1 year ago • 2 comments

Fix handling of missing QRG for log entry sent via LAN.

dl1jbe avatar Oct 03 '24 15:10 dl1jbe

Frequency is correctly stored, but see the comments.

zcsahok avatar Oct 04 '24 19:10 zcsahok

Thanks for review. See answers inline.

dl1jbe avatar Oct 05 '24 12:10 dl1jbe

How about this plan?

  1. in this PR keep only the minimal changes to get freq into the log and also remove the code for dropping the last char of the LAN message.
  2. document LAN messages in the manual
  3. test to see if messages work as required and fix the arising issues.

I can help with 2) and 3).

zcsahok avatar Oct 09 '24 05:10 zcsahok

See the last commit to see a more developed state after harmonizing the sent code.

But, let us discus your plan.

1. in this PR keep only the minimal changes to get freq into the log and also remove the code for dropping the last char of the LAN message.

Ok, rework of the commits can be made easily. I would make a new PR for it. (Maybe not before friday). But I would still recommend to send ALL message NL terminated in the end (makes debugging more easy). So no need to drop the last char.

2. document LAN messages in the manual

Or maybe better in the code, e.g. in lancode.h. I think the message format is not relevant for normal user.

3. test to see if messages work as required and fix the arising issues.

I can help with 2) and 3).

Fine by me.

dl1jbe avatar Oct 09 '24 12:10 dl1jbe

Thanks for the updates. I still see no need for the NL, but can live with it. You can use this PR, no separate one is needed IMO.

Re 2): lancode.h is also a perfect place to document the messages.

zcsahok avatar Oct 09 '24 17:10 zcsahok

That should be step 1. Using g_strchomp is a good idea.

dl1jbe avatar Oct 11 '24 11:10 dl1jbe

Thanks for the update.

zcsahok avatar Oct 13 '24 19:10 zcsahok