tiatoolbox icon indicating copy to clipboard operation
tiatoolbox copied to clipboard

🆕 Address `TIAViz` Review Comments

Open measty opened this issue 1 year ago • 1 comments

This PR makes a collection of changes related to reviewer comments in the TIAViz paper.

Main changes are:

  1. Layer names in the interface for static image overlays now are named after filename stem, instead of generic 'layer1', 'layer2' etc to make it easier to distinguish the layers.
  2. Adds multipoint geometry rendering as qupath exports collections of points as multipoints not individual point annotations
  3. Robustifies qupath import from geojson to handle qupath special case of nucleusGeometry.

measty avatar Jul 31 '24 13:07 measty

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 99.09%. Comparing base (318aa32) to head (caab28d). :warning: Report is 13 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #841      +/-   ##
===========================================
- Coverage    99.70%   99.09%   -0.62%     
===========================================
  Files           71       71              
  Lines         9141     9160      +19     
  Branches      1190     1196       +6     
===========================================
- Hits          9114     9077      -37     
- Misses          23       59      +36     
- Partials         4       24      +20     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 29 '25 16:05 codecov[bot]

Thanks @measty It looks good to me.

I have added a few comments and there are some conflicts to resolve before we merge.

I've addressed the comments and the conflict, looks like I still need to add a test though

measty avatar Aug 14 '25 20:08 measty