UserChrome-Tweaks icon indicating copy to clipboard operation
UserChrome-Tweaks copied to clipboard
verified publisher icon Timvde

Add stylelint

Open nt1m opened this issue 8 years ago • 4 comments

The CSS files should be linted to have a common code style + no errors.

nt1m avatar Sep 06 '17 01:09 nt1m

I think that would make sense when there is a proper management UI. Common users don't like reading console logs...

Madis0 avatar Sep 06 '17 03:09 Madis0

I can at least manually run this before merging to master, so this sounds like a good idea already. I try to manually enforce the same style, but I can definitely overlook something.

I have no experience with CSS linting tools though. I'll look into stylelint later today.

Timvde avatar Sep 06 '17 05:09 Timvde

@Madis0 By the way, a linting tool would only make sense for contributors, not for users. So a console tool would be fine imo.

Timvde avatar Sep 06 '17 05:09 Timvde

You could make a travis job that disallows merging the PR until all stylelint issues are solved.

nt1m avatar Sep 06 '17 12:09 nt1m