laminar icon indicating copy to clipboard operation
laminar copied to clipboard

Implement immediate mode API

Open kstrafe opened this issue 6 years ago • 1 comments

This is a PR to just get a discussion going about a potential immediate-mode API. This API does not require the user to be concerned with manual_poll or start_polling, and instead does everything via the send and recv calls (now called _immediate for convenience of implementation).

Regarding performance, we can configure whether to run resending, polling the underlying socket, handle idle clients as a function of the Nth recv/send. Ideally we can run all this at every call to avoid any unexpected "why doesn't my packet arrive?" questions.

kstrafe avatar Jun 24 '19 06:06 kstrafe

Codecov Report

Merging #212 into master will decrease coverage by 0.25%. The diff coverage is 81.08%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #212      +/-   ##
=========================================
- Coverage   97.45%   97.2%   -0.26%     
=========================================
  Files          25      25              
  Lines        2321    2358      +37     
=========================================
+ Hits         2262    2292      +30     
- Misses         59      66       +7
Impacted Files Coverage Δ
src/net/socket.rs 94.93% <81.08%> (-1.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf65f8a...ca7dd7d. Read the comment docs.

codecov[bot] avatar Jun 24 '19 07:06 codecov[bot]