ticalc-usb icon indicating copy to clipboard operation
ticalc-usb copied to clipboard
verified publisher icon Timendus

Fix special var names

Open Timendus opened this issue 4 years ago • 2 comments

Closes #32

This should hopefully be a fix for the issues with sending variables with special characters in their names. Probably needs a bit more testing, but this at least fixes sending programs with a θ in their name for me.

If anyone is in the mood to give this a test themselves, that would be much appreciated. Otherwise I'll test it some more and see if I run into any more issues myself.

A question that I had while doing this: what encoding does the "comment" field in a TI file use?

TODO

  • [ ] Fix indentation mismatches
  • [ ] Test more weird characters
  • [ ] Check CodeClimate issues

Timendus avatar Nov 22 '21 22:11 Timendus

The comment field isn't exposed by TI to the user AFAIK so I guess you can just use normal ASCII. But regardless, it's 42 free bytes, they could be anything!

adriweb avatar Nov 23 '21 22:11 adriweb

This PR probably still has a bug. Programs with special characters in their name can't be deleted normally from the calculator.

Timendus avatar Dec 20 '21 16:12 Timendus