Tim Düsterhus

Results 269 comments of Tim Düsterhus

> Maybe we should figure a way to send a GOAWAY frame with no error This would be great, yes. > even be used to kill all idle H2 client...

Hi! Thank you for the PR. Unfortunately I've not yet had the time to investigate this and I don't want to commit to a particular “easy” solution that might not...

> how can I fix this issue? This will need a fix in https://github.com/TimWolla/docker-adminer/blob/48079bec8bcc9f91752cf55a1d4ad66667520543/5/entrypoint.sh#L4-L10 to handle dark-mode styles. I'll need to investigate how exactly they work, e.g. whether symlinking adminer.css...

> Well, if I get Tim's comment [here](https://github.com/docker-library/php/pull/1587#issue-3175022371) For PHP 8.4 and earlier it will not break anything. For PHP 8.5 OPcache does not exist as a separate module, which...

> The "feature" warning seems like it would be overkill. I find it appropriate. This what it's for. See also: https://www.php.net/manual/en/info.configuration.php#ini.assert.active where the snippet is used for various INIs.

> I'm not sure what to do with the changelog here. I'm not sure we need the changelog. I don't think this was previously done for similar pages / it...

> or poke upstream and see if i386 is even supported / if this is something they want to fix I'm pretty confident that i386 (or 32 bit in general)...

Especially since: ``` ALWAYS_PAD(6); // 6 bytes hole, ensure it remains the same size 32 vs 64 bits arch ```