Tim Knight

Results 115 comments of Tim Knight

@amimas in GL 17 I don't think there _will_ be an enable true/false option, simply there will be an allowlist, so we shouldn't have to worry about accounting for this,...

GL have implemented Group addition to allowlist via REST: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/145069 So suspect similar API would be ``` group-foo/project-abc: job_token_scope: enabled: false allowlist: groups: - group-bar ``` _or_ ``` group-foo/project-abc: job_token_scope:...

FYI I'll probably be contributing into `python-gitlab` https://github.com/python-gitlab/python-gitlab/pull/2767 to help add this functionality into there first

@amimas - the `groups_allowlist` at least is only being released in 16.10 (March 21st), I'm working on the python-gl implementation on my fork: https://github.com/python-gitlab/python-gitlab/pull/2816 Is there a way I can...

@amimas yes you're right, that's my reading of the deprecation notices too. Let's call the first boolean `limit_access_to_this_project` ? bit wordy _but_ does map to Gitlab?

Nevermind, they swap between terminology throughout the API and UI for this setting 🙈 ..... Maybe GLF should be consistent and make it do what it says, or at least...

I've tested it, spoken to our contact at Gitlab (the benefits of working somewhere with Ultimate license), and raised an MR to clarify Gitlab's REST api documentation based on what...

Yes, that was just me stream of thoughting into the comments :D

@amimas @nickgriffiths changes to support this are here: https://github.com/TimKnight-DWP/gitlabform/pull/1 Currently on my fork only because I need to point at my fork of python-gitlab to pick up that part of...

@amimas @hertzsprung changes to support this are here: https://github.com/TimKnight-DWP/gitlabform/pull/1 Currently on my fork only because I need to point at my fork of python-gitlab to pick up that part of...