TileDB icon indicating copy to clipboard operation
TileDB copied to clipboard
verified publisher icon TileDB-Inc

Update to use new route for group creation.

Open shaunrd0 opened this issue 8 months ago • 2 comments

Recently the route for group creation was updated from {workspace}/{teamspace} POST to {workspace}/{teamspace}/{group} POST. This updates post_group_create_to_rest to call the new endpoint if we are not communicating with a legacy REST server.

TYPE: BUG DESC: Update to use new route for group creation.

shaunrd0 avatar Jun 11 '25 20:06 shaunrd0

The endpoint has been changed which causes a 404 when creating a group. But it looks like the new endpoint is not using full URIs like we have in the past for other endpoints, instead it's using a group path like parent_group/child/. The full group URI is still serialized in GroupCreateDetails. Flipping this to draft since this PR isn't quite right yet.

shaunrd0 avatar Jun 11 '25 21:06 shaunrd0

The endpoint has been changed which causes a 404 when creating a group. But it looks like the new endpoint is not using full URIs like we have in the past for other endpoints, instead it's using a group path like parent_group/child/. The full group URI is still serialized in GroupCreateDetails. Flipping this to draft since this PR isn't quite right yet.

We need to work with Server folks to understand why this change to the group routes was needed and what are the implications. This affects more than just group create, I think it affects pretty much all group operations at this point. Let's investigate so that we resort to changes in Core as a last choice.

ypatia avatar Jun 12 '25 10:06 ypatia

I think now this PR addresses all required changes for groups, however I have found issues while testing manually end to end. I have documented the issues here. They are namely errors in adding group members and in creating groups with default storage. I believe those should all be server issues, but we need to investigate further and resolve before this can be merged I think. I haven't yet run REST-CI against the server, I don't have a setup in hand and I think this can wait until we have resolved the issues I found first.

ypatia avatar Jun 25 '25 11:06 ypatia

@shaunrd0 let me know if you are ok with my latest changes and I'll approve and merge.

ypatia avatar Jul 07 '25 10:07 ypatia

LGTM, thanks!

shaunrd0 avatar Jul 07 '25 18:07 shaunrd0

/backport to release-2.28

ypatia avatar Jul 11 '25 07:07 ypatia

Started backporting to release-2.28: https://github.com/TileDB-Inc/TileDB/actions/runs/16214577327

github-actions[bot] avatar Jul 11 '25 07:07 github-actions[bot]