TileDB icon indicating copy to clipboard operation
TileDB copied to clipboard
verified publisher icon TileDB-Inc

Update to use `post_array_schema_from_rest`.

Open shaunrd0 opened this issue 1 year ago • 3 comments

This updates internal get_array_schema_from_rest calls to post_array_schema_from_rest added in https://github.com/TileDB-Inc/TileDB/pull/4399. This also fixes array schema evolution time traveling issues reported in SC-49827 caused by not using timestamps to open the array for tiledb:// URIs.

[sc-32991]

TYPE: NO_HISTORY DESC: Update to use post_array_schema_from_rest.

shaunrd0 avatar Jul 11 '24 19:07 shaunrd0

🚀 Can we open the PR now?

Yep marked ready for review, looking at CI failures now

shaunrd0 avatar Jul 22 '24 16:07 shaunrd0

Moving to draft to not accidentally merge before fixing the TILEDB_CLOUD_REST_REF branch.

ypatia avatar Jul 24 '24 09:07 ypatia

I think this PR in its current format creates a chicken and egg situation. Long story short we can't be introducing CAPNP changes in the same PR as we are enabling a REST request that will need to be handled server-side by deserializing that changed CAPNP model. Not at all confusing 😅 As a rule of thumb CAPNP changes need to happen in a previous release than the one that sends a request to the route that will be using that CAPNP. My suggestion is to break this PR in 2:

  • One with the CAPNP changes & anything related to just this (ser/deser functions etc) that we'll merge asap and backport to 2.25.X in hope of a maintenance release that will get that in soon.
  • One with the C-API logic and is_tiledb() - rest_client changes that enables hitting the route on the REST Server.

Hope it makes sense and sorry I didn't catch that earlier :(

ypatia avatar Aug 08 '24 08:08 ypatia