lums/sc 28282/wait returns

[lums658]

Applied a number of fixes to code in the experimental task graph code so that it would compile cleanly under msvc, notably the issue with wait_returns that was generating a massive number of error messages. Following that, cleaned up some remaining warnings and error messages.

Note however, that several of the build errors that were exhibited when compiling the experimental task graph branch may require a fair amount of time to fix. Since none of the remaining issues are on the critical path for migrating the current task graph prototype to the production version, the problem unit tests have been commented out so that the experimental branch will build cleanly under CI.

Nevertheless, some of the issues will eventually need to be addressed.

The particular issues are:

• The PoolAllocator class currently takes a non-template parameter (the desired size of the data block). While this works elsewhere, the expected member types don't behave properly in msvc. The PoolAllocator will need to have another level of indirection so that the user sees an allocator taking a particular type, and then underneath the allocator returns data blocks of the appropriate size. All of the unit tests that use the DataBlock (and therefore PoolAllocator) have been disabled for msvc.
• unit_taskgraph (et al) are failing due to some CTAD failures when instantiating Edge. Something related may need to be done in the production version, so it may be worth making this work in the prototype version.
• unit_nodes_sieve has some of its own difficulties with CTAD. But the set of tests we had been using to benchmark the prototype as it was being developed will need to be rewritten for the production version at any rate, so this might not be worth trying to fix.

Of these, the only must-fix is the PoolAllocator. However, this has not yet been used in any parts of the prototype task graph and may not be used for some time in the production version.

There is a new story (sc-28388) for these issues.

---

TYPE: BUG DESC: Fixed isses in experimental task graph files that were causing MVC

[shortcut-integration[bot]]

This pull request has been linked to Shortcut Story #28282: Fix MSVC compilation errors in experimental tree..

[KiterLuc]

Closing for now. We have tracking stories that link to this PR when we decide to resume that work.