TileDB-Go icon indicating copy to clipboard operation
TileDB-Go copied to clipboard

Wrap tiledb_handle_load_array_schema_request

Open davisp opened this issue 2 years ago • 3 comments

This wraps the new tiledb_handle_load_array_schema_request function in TileDB.

I was a bit unsure of where to put this. But based on the prior art for DeserializeLoadEnumerationsRequest, I stuck it in array_schema.go.

There's also at least one more of these coming for another handler though. So if you want me to create a new handlers.go or cloud_handlers.go or some such, I could also move the Enumeration handler and add the third all in one PR if that's preferable.

Also, I have no idea on Go style guides. I just know that this compiles. When I run go fmt locally it changes a lot of things that do not appear as they should changed so I've not run it and am just crossing my fingers I aped the DeserializeLoadEnumerationsRequest code closely enough.

davisp avatar Oct 20 '23 19:10 davisp

Some of those test failures look like version incompatibilities and I can't decipher the others. I'm no Go expert so feel free to poke me with a clue stick if I've missed anything obvious.

Also, I believe this is the first ever Go PR I've ever submitted which is very exciting.

davisp avatar Oct 20 '23 20:10 davisp

@davisp the PR is OK. The tests fail because it is build against a TileDB 2.17.4 build. To eliminate the test failures you can cherry-pick the yaml commits of https://github.com/TileDB-Inc/TileDB-Go/pull/279 or wait for a TileDB 2.18 release before resubmitting. No code changes are needed but cannot be merged until TileDB 2.18 is released which will lead to TileDB-Go 0.24

anastasop avatar Nov 14 '23 10:11 anastasop

This work has been covered by this https://github.com/TileDB-Inc/TileDB-Go/pull/329 , closing as not needed anymore.

ypatia avatar Jul 19 '24 09:07 ypatia