tibiadata-api-go icon indicating copy to clipboard operation
tibiadata-api-go copied to clipboard

bug: character killer last two incorrect if combination traded and summon

Open MichalNawrocik opened this issue 1 year ago • 4 comments

Character Sergiozk Crushed at Level 597 by Irynn, Indio Pedibrek, Tenoriio Rex, Pitucola, Lekinho Destroyer, Sergiozk, Aperninha de grilo, Bino Pally Rox, Experience Hunter, Lohana Darkside, Flavzk (traded) and paladin familiar of Fllockyy.

Actual parsing:

{
  "name": "Flavzk and paladin familiar of Fllockyy",
  "player": true,
  "traded": true,
  "summon": ""
}

Expected parsing:

{
  "name": "Flavzk",
  "player": true,
  "traded": true,
  "summon": ""
},
{
  "name": "Fllockyy",
  "player": true,
  "traded": false,
  "summon": "paladin familiar"
}

So the last two killers are wrongfully shown as one.

rel #344 (maybe)

MichalNawrocik avatar Apr 03 '24 23:04 MichalNawrocik

Since the wrongfully parsed death already disappeared from tibia.com, I attach an earlier copy of that character's page. It's a HTML file but .htm/.html extension is not allowed here so I changed the extension to .txt.

Sergiozk.txt

MichalNawrocik avatar Apr 09 '24 08:04 MichalNawrocik

@MichalNawrocik thanks for uploading the file!

There is actually an additional death on the Sergiozk character that has the same issue. Created bug-341-killer-parsing-issue branch and pushed the html testdata and prepared the test for Sergiozk.

tobiasehlert avatar Apr 09 '24 10:04 tobiasehlert

There also seems to be something off with the summon parsing, so I've created #344 separately for that.. this gets resolved automatically by resolving that one first.

tobiasehlert avatar Apr 09 '24 10:04 tobiasehlert

It seems it also happens when there's no summon involved, just a traded character one before the last killer. Example: Character Bobzeira da Bahia Slain at Level 438 by Michelllzin Oic, Kvrzerah synkrolestw boskich, Material Cientifico, Ursulino Slylabiano, Rafaazim One, Rizoflora (traded) and Aindaa Nao.

Actual parsing:

{
  "name": "Rizoflora and Aindaa Nao",
  "player": true,
  "traded": true,
  "summon": ""
}

Expected parsing:

{
  "name": "Rizoflora",
  "player": true,
  "traded": true,
  "summon": ""
},
{
  "name": "Aindaa Nao",
  "player": true,
  "traded": false,
  "summon": ""
}

MichalNawrocik avatar Apr 14 '24 22:04 MichalNawrocik