Feature: Tibia Char Bazaar endpoints

Open tobiasehlert opened this issue 4 years ago • 4 comments

This feature includes following endpoints:

current auctions
auction history
auction details

Original PR was #23

Jan 04 '22 20:01 tobiasehlert

Working on this. I will have the refactor changes according to SonarCloud Code Analysis soon.

Can we elaborate a bit more on the current auctions and auction history endpoints ? Are these endpoints going to retrieve only the auctions that appear in the main page or should we add pagination ?

Jan 04 '22 22:01 pheizx

Working on this. I will have the refactor changes according to SonarCloud Code Analysis soon.

Can we elaborate a bit more on the current auctions and auction history endpoints ? Are these endpoints going to retrieve only the auctions that appear in the main page or should we add pagination ?

Yeah, there where a couple of notes from SonarCloud so some things should be renamed/rewritten. But yes, we definitely need pagination so that people can retrieve "all" current and historical auctions.

Jan 04 '22 22:01 tobiasehlert

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

Jan 19 '22 21:01 sonarqubecloud[bot]

Codecov Report

Merging #24 (be534bc) into main (ce26e50) will decrease coverage by 8.52%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   58.38%   49.85%   -8.53%     
==========================================
  Files          21       22       +1     
  Lines        2595     3039     +444     
==========================================
  Hits         1515     1515              
- Misses       1023     1467     +444     
  Partials       57       57

Jan 19 '22 21:01 codecov[bot]