FluentDOM icon indicating copy to clipboard operation
FluentDOM copied to clipboard

Support PHP 8.1 better

Open xvilo opened this issue 3 years ago • 3 comments

Currently this library emits a lot of warnings on PHP. An example:

Deprecated: Return type of FluentDOM\Serializer\Factory\Group::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /src/fluentdom/fluentdom/src/FluentDOM/Serializer/Factory/Group.php on line 75

These should be fixed

xvilo avatar Aug 15 '22 13:08 xvilo

@ThomasWeinert Do you happen to have time for this? This interferes a lot with our automated code checking.

beerendlauwers avatar Jan 09 '23 12:01 beerendlauwers

I would also like FluentDOM to work with PHP 8

Rikardsen avatar Aug 14 '23 07:08 Rikardsen

Please check the refactor/php8 branch.

ThomasWeinert avatar Oct 22 '23 09:10 ThomasWeinert