WidescreenFixesPack icon indicating copy to clipboard operation
WidescreenFixesPack copied to clipboard

[NFS ProStreet] Player settings sometimes reset when ResDetect is enabled

Open berkayylmao opened this issue 3 years ago • 3 comments

ResDetect, if not loaded timely, can cause the game to reset all settings. To repro just enable ResDetect and launch&close the game a few times. In my opinion, just forcing a resolution from the ini is both easier and more stable.

berkayylmao avatar Aug 08 '22 14:08 berkayylmao

I can't seem to reproduce this, oddly enough. But if I'm understanding you correctly, wouldn't it be better to disable the game code responsible for the reset rather than replacing ResDetect? We had to do something similar for the Silent Hill games, since the same problem would occur when using ALT+F4 to close the game.

While I don't personally mind (I can't speak for ThirteenAG) the idea of removing ResDetect and going with an ini solution, some people have expressed their dislike for this method and might see it as a downgrade.

AeroWidescreen avatar Aug 09 '22 14:08 AeroWidescreen

Hmm, that is possible. I have noticed a combination of ResDetect and crashes cause the reset to happen the most. I will take a look into it and post an update here.

berkayylmao avatar Aug 09 '22 22:08 berkayylmao

Well yes, it is more stable to just force a res, on the same token that resolution force can also not load in a timely manner. I guess this is just a case of the hook being slow.

I have no idea why exactly it causes a reset. I suppose it freaks the game out when there is no ResDetect and causes an OOB in the resolution array (in case there is an unknown res set), but this should only affect settings stored in the registry and not actual player settings (which should be stored in the save file).

This same code is present in Undercover, so you should be able to reproduce it there as well.

I guess a fix could be just to relocate that setting to the ini of the ASI and make it read from the ini file instead and leave the registry settings alone.

Having resolutions accessible directly from the game menu is better for the user experience. Not many people like fiddling around with inis, so we should try our best to keep that part to a minimum.

xan1242 avatar Aug 15 '22 00:08 xan1242