Théo Jolivet

Results 18 comments of Théo Jolivet

Should we add this for all BaseEstimators ?

Thanks a lot @Vincent-Maladiere ! To answer your points: 1. I can remove `_check_dataframes` and use `CheckInputDataFrame`, I just need to handle the case where `aux_table="X"` to keep the option...

If think the PR is good for a second pass. I probably need to rename it and add some extra things in the changelog. @Vincent-Maladiere I addressed points 1 &...

After discussion with @GaelVaroquaux, it was decided we won't make selectors public here. Let's open a meta issue on their support and documentation first > Let's aim to remove `_namespace.py`,...

For the appearance, my vote goes to striped table, shadows on cards, no selected cell outline. If there's a poll somewhere I'm happy to share it there

Agreed ! It would also be useful to check dataframe types between `main` and `aux`. For now, I believe only `AggJoiner` checks that both have the same type in `X,...

I like the option of having the filter, it could be useful for (i) users that want the same columns they were seeing in the "Table preview" and "Column summaries"...

Agree that this would be very useful. For now, the best I've found is to add ``reasoning: str`` to the top of the type, which significantly improves performance (both for...